3613 - Setting default query doesn't work completely...

Status: RESOLVED WORKSFORME

(Bugzilla :: Query/Bug List, defect, P2)

Description

[Jan Carpenter]

- In the section where you search on email address, it doesn't save my email
address.
- Also in that section it saves the checkmarks for "Assigned To" and "Reporter"
even if you unclick them and click something else.

Comment 1

[Terry Weissman]

Reassigning to [e-mail], who now has front-line responsibility for
all Bonsai and Bugzilla bugs.

Comment 2

[Terry Weissman]

Reassigning back to me.  That stuff about me no longer being the front-line
person responsible for Bugzilla and Bonsai turned out to be short-lived.
Please pardon our confusion, and I'm very sorry about the spam.

Comment 3

[Terry Weissman]

This has been mostly fixed for a long time, and I just checked in a patch to fix
the rest of it.

Comment 4

[Dave Miller [:justdave]]

per Terry, auto-verifying any resolved bug that hasn't been touched since before 
2.10 was released.

Comment 5

[[e-mail]]

I (still) can't save the "Assigned To" and "Reporter" checkboxes as unchecked.
Should I file a new bug?

Comment 6

[Terry Weissman]

Per the last comment, I am reopening this bug (and will then reassign it to
someone more actively involved in Bugzilla than I am these days.)

Comment 7

[Terry Weissman]

Reassigning to someone who is more likely to look at this someday...

Comment 8

[Matthew Tuck [:CodeMachine]]

Confirmed.  If you turn off all the checkboxes (except possibly Added Comment),
these two checkboxes get turned on.

Comment 9

[Jacob Steenhagen]

I noticed this in my failed attempt at making a patch for bug 64946.  I will
should be able to pull the relevant stuff out of the patch on that bug to make
this work properly.

Comment 10

[Gervase Markham [:gerv]]

Jake: what are your plans for this bug? ;-)

Gerv

Comment 11

[Jacob Steenhagen]

Attachment: Patch

Comment 12

[Jacob Steenhagen]

Actually, I'd forgotten all about it :)

This doesn't let you save all boxes unchecked (I'm not sure why you'd even want
to do that), but it does let you save "Added Comment" as the only checked box
(which doesn't work w/out this patch).

Comment 13

[Gervase Markham [:gerv]]

The templatisation has changed query.cgi so much that I doubt this patch is
relevant. I'm pretty sure saved queries now save everything.

Gerv

Comment 14

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 15

[Dave Miller [:justdave]]

I'm betting the patch here is completely bitrotted now that bug 98707 is in.  We
should double-check if the check-in for bug 98707 fixed this... if not, how much
fixup does this need to be compatible with the new query page?

Comment 16

[Jacob Steenhagen]

Yep, now that bug 98707 is in, this works properly (although it took me a while
to find where this box had moved to :)