361362 - js/src/jsemit.c assumes sizeof(int) == sizeof(ptrdiff_t)

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Martin Husemann]

Obviously this does not work on plattforms where sizeof(int) != sizeof(ptrdiff_t):

int noteIndex;
EmitVariables(cx, cg, pn, JS_FALSE, &noteIndex);

For example on NetBSD/sparc64 this makes firefox (and regchrome during installation) dump core due to a bus error - int has four byte alignement, while ptrdiff_t requires eight byte alignment.

Comment 1

[Martin Husemann]

Attachment: Change a variable from int to ptrdiff_t to assure proper alignment

This is how I patched it locally (in NetBSD's pkgsrc), which made it work for me.

Comment 2

[Brendan Eich [:brendan]]

Fixed on trunk, thanks:

$ cvs ci -m"Fix from Martin Husemann <[e-mail]> for int-instead-of-ptrdiff_t abusage (361362, r=me)." jsemit.c
Checking in jsemit.c;
/cvsroot/mozilla/js/src/jsemit.c,v  <--  jsemit.c
new revision: 3.229; previous revision: 3.228
done

/be

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 246128 [details] [diff] [review]
Change a variable from int to ptrdiff_t to assure proper alignment

Safe portability fix.

/be

Comment 4

[Jay Patel [:jay]]

Comment on attachment 246128 [details] [diff] [review]
Change a variable from int to ptrdiff_t to assure proper alignment

Approved for landing on both 1.8.0 and 1.8.1 branches, a=jay for drivers.

Comment 5

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch:

Checking in jsemit.c;
/cvsroot/mozilla/js/src/jsemit.c,v  <--  jsemit.c
new revision: 3.128.2.60; previous revision: 3.128.2.59
done

and on the 1.8.0 branch:

Checking in jsemit.c;
/cvsroot/mozilla/js/src/jsemit.c,v  <--  jsemit.c
new revision: 3.128.2.3.2.13; previous revision: 3.128.2.3.2.12
done

/be

Comment 6

[Martijn Wargers (dead)]

Verified fixed on trunk, 1.8.1 branch and 1.8.0.x branch by code inspection.