361424 - month view day boxes should draw eventboxes in a batch

Status: RESOLVED INVALID

(Calendar :: Calendar Frontend, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

addItem is the only way to add items to a day box in the month view, leading to the conclusing that during a month switch, all items are added with a call to addItem. But addItem will relayout. So if you have 5 items on one day, you will relayout five times in quick succession. That seems silly. If we set a batch mode on the day boxes, they would not relayout until the batch end, or maybe after a given time interval (this is needed for the async providers, where it could take some time for all events to come in) 

(that's a quote from a newsgroup post)

Comment 1

[Simon Paquet [:sipaq]]

mvl, is this bug still current?

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Same question as 2 years ago :-)

Comment 3

[Simon Paquet [:sipaq]]

Here's what I came up with:

sipaq	mvl: how could I find out if that bug is still current?
mvl	sipaq: lots of code inspection
mvl	or dump statements, and a good testcase
sipaq	where would I start to look? in the relayout function?
mvl	I guess so.
mvl	relayout for the individual day boxes
mvl	then see how often it gets called when N events are added to it
mvl	added, as in: switch to a month with a day with N events in it, rest of 
        the month is best empty
sipaq	ok, I looked through both relayout methods and couldn't find anything 
        that looks like a batch implementation
sipaq	http://mxr.mozilla.org/comm-central/search?find=%2Fcalendar%2Fbase%2Fcontent%2F&string=batch 
        says so as well, if I read it correctly

Comment 4

[David :Bienvenu]

Is this a blocker? If we can't tell if it's still happening, it seems like it might not be.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Agreed

Comment 6

[Wayne Mery (:wsmwk)]

Or do https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Reporting_a_Thunderbird_Performance_Problem_with_G

Comment 7

[Decathlon]

I've taken a look to the old code (Sunbird 1.0) and at that time there was a call to the relayout() function inside addItem() so there was a relayout every time an item-box was added to the view, but now this doesn't happen anymore.
With a dump() inside relayout [1] can be verified that when switching the month in month-view, there is only one relayout irrespective of the number of item-boxes in the view (inside one day-box or many day-boxes).

Unless the relayout mentioned in comment 0 is something different than [1], this bug can be closed.


[1] http://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-month-view.xml#701

Comment 8

[Wayne Mery (:wsmwk)]

OK to close per comment 7?

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Sure thing, fine with me