361432 - style lines from manifest files no longer applied when xul cache disabled

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Dave Townsend [:mossop]]

Stylesheets specified as style lines in chrome manifest files rather than as xml pi's are no longer applied to the document.

Regression range is 2006111104 to 2006111204

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1163246341&maxdate=1163336280

Choosing to blame bug 319654

Comment 1

[Benjamin Smedberg]

We shouldn't ship alpha1 with this, IMO.

Comment 2

[Nickolay_Ponomarev]

I'm looking into it. My debug builds don't have this problem, will have to do a clean debug build and an opt build.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Dave, do you have particular steps to reproduce?  Is a particular extension involved?

Comment 4

[Dave Townsend [:mossop]]

Discovered that this only occurs when the xul cache is disabled, so possibly not so much of a problem.

Opening the customize toolbar dialog should demonstrate the problem, most of the items are without their icons.

Comment 5

[Nickolay_Ponomarev]

Attachment: patch

Duh.

Comment 6

[Nickolay_Ponomarev]

Comment on attachment 246353 [details] [diff] [review]
patch

I meant to do this when I removed the loading code from EndLoad.

The fact that I don't remove the IsChromeURI check does mean that non chrome sheets from the chrome registry won't get loaded, like I guess they used to. I think it's ok, since they were never handled well by the old code (which didn't add them to prototype's sheets).

Comment 7

[Boris Zbarsky [:bzbarsky]]

Need to document the change comment 6 describes.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 246353 [details] [diff] [review]
patch

Makes sense.   r+sr=bzbarsky

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/content/xul/document/src/nsXULDocument.cpp 	1.741

Comment 10

[Eric Shepherd [:sheppy]]

I'm unclear on what needs documenting here.  It looks like a one-line change that fixes a bug; is it something that people actually need specifically documented?  I'm just not sure where it would go.

Comment 11

[Dave Townsend [:mossop]]

Added the note I think appropriate at http://developer.mozilla.org/en/docs/Chrome_Registration#style

Comment 12

[Nickolay_Ponomarev]

That's correct.(In reply to comment #11)
> Added the note I think appropriate at
> http://developer.mozilla.org/en/docs/Chrome_Registration#style
> 
Thanks, that's the note that should have been added.