Closed Bug 36145 Opened 22 years ago Closed 14 years ago

GetWidth optimizations need to be implemented on Mac (text measurement performance)

Categories

(Core :: Layout: Text and Fonts, defect, P3)

PowerPC
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla1.5alpha

People

(Reporter: sfraser_bugs, Assigned: sfraser_bugs)

References

Details

(Keywords: perf, platform-parity)

troy implemented a version of nsRenderingContext::GetWidth that measures text in 
larger chunks, for performance reasons. This needs to be implemented on Mac too.
Keywords: perf
Status: NEW → ASSIGNED
Target Milestone: --- → M16
Accepting the bugs
Target Milestone: M16 → M18
This bug has been marked "future" because the original netscape engineer working
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way
-- please attach your concern to the bug for reconsideration.
Add helpwanted.
Keywords: helpwanted
FOrgot to set the milestone.
Target Milestone: M18 → Future
Reassigned to Gary Wade who doesn't look as doomed as we are.
Assignee: waqar → garywade
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Keywords: pp
gary no longer work for us. reassing to ftang
Assignee: garywade → ftang
Status: ASSIGNED → NEW
Keep this as P3 future.
Status: NEW → ASSIGNED
Frank, considering how much of an improvment this made on Windows I'd love to see 
it make it into the Mac sooner rather than later.  
Assignee: ftang → sdagley
Status: ASSIGNED → NEW
Target Milestone: Future → mozilla0.9
Target Milestone: mozilla0.9 → mozilla0.9.1
Setting target milestone to 0.9.2 (check it in anytime, even before, when the
tree is open for). Per PDT triage.
Target Milestone: mozilla0.9.1 → mozilla0.9.3
After discussion with ftang this isn't considered a significant performance 
improvement on Mac (based on the different costs of text measurment on windows 
and some work gary wade had done on the Mac) and is back to being FUTURE'd.  If 
we revisit this again we should see if gary still has the code he worked on as 
the drop he gave ftang can't be found.
Target Milestone: mozilla0.9.3 → Future
Summary: GetWidth optimizations need to be implemented on Mac → GetWidth optimizations need to be implemented on Mac (text measurement performance)
This will be big for ATSUI rendering. Taking.
Assignee: sdagley → sfraser
Keywords: helpwanted
Summary: GetWidth optimizations need to be implemented on Mac (text measurement performance) → GetWidth optimizations need to be implemented on Mac
Target Milestone: Future → mozilla1.0
Summary: GetWidth optimizations need to be implemented on Mac → GetWidth optimizations need to be implemented on Mac (text measurement performance)
See the GTK patch on bug 36146.
Sorry, I lost that code some time ago when my hard drive had a very bad 
crash.

The changes I coded only provided a minimal speed-up since they were 
within the context of the cross-platform calls.  What they did was to cache 
the ATSUI measurements of each GetWidth call.

If the current minimum OS requirements provide it, two better calls to use 
now would be ATSUGlyphGetScreenMetrics (only on 9.1 and later) and 
ATSUGetGlyphBounds (only on 8.6 and later).  If these APIs are in the 
underlying system, they should provide the needed functionality to 
increase the performance as desired.
Attachment 75538 [details] [diff] in bug 121540 contains an implementation of the GetWidth
optimization for Mac QuickDraw, and ATSUI. In my tests, this gave us a pageload
boost of about 5%.
To 1.1
Target Milestone: mozilla1.0 → mozilla1.1alpha
Status: NEW → ASSIGNED
Target Milestone: mozilla1.1alpha → mozilla1.5alpha
Depends on: atsui
This bug is targeted at a Mac classic platform/OS, which is no longer supported
by mozilla.org. Please re-target it to another platform/OS if this bug applies
there as well or resolve this bug.

I will resolve this bug as WONTFIX in four weeks if no action has been taken.
To filter this and similar messages out, please filter for "mac_cla_reorg".
OS: Mac System 8.5 → MacOS X
Component: Layout → Layout: Fonts and Text
Pretty much, yeah. I'll mark it FIXED.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.