36145 - GetWidth optimizations need to be implemented on Mac (text measurement performance)

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Simon Fraser [no longer active]]

troy implemented a version of nsRenderingContext::GetWidth that measures text in 
larger chunks, for performance reasons. This needs to be implemented on Mac too.

Comment 1

[waqar]

Accepting the bugs

Comment 2

[Frank Tang]

add cc [e-mail]

Comment 3

[waqar]

This bug has been marked "future" because the original netscape engineer working
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way
-- please attach your concern to the bug for reconsideration.

Comment 4

[Simon Fraser [no longer active]]

Add helpwanted.

Comment 5

[waqar]

FOrgot to set the milestone.

Comment 6

[Pierre Saslawsky]

Reassigned to Gary Wade who doesn't look as doomed as we are.

Comment 7

[Frank Tang]

gary no longer work for us. reassing to ftang

Comment 8

[Frank Tang]

Keep this as P3 future.

Comment 9

[Steve Dagley]

Frank, considering how much of an improvment this made on Windows I'd love to see 
it make it into the Mac sooner rather than later.  

Comment 10

[Marek Z. Jeziorek]

Setting target milestone to 0.9.2 (check it in anytime, even before, when the
tree is open for). Per PDT triage.

Comment 11

[Steve Dagley]

After discussion with ftang this isn't considered a significant performance 
improvement on Mac (based on the different costs of text measurment on windows 
and some work gary wade had done on the Mac) and is back to being FUTURE'd.  If 
we revisit this again we should see if gary still has the code he worked on as 
the drop he gave ftang can't be found.

Comment 12

[Simon Fraser [no longer active]]

This will be big for ATSUI rendering. Taking.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See the GTK patch on bug 36146.

Comment 14

[Gary L. Wade]

Sorry, I lost that code some time ago when my hard drive had a very bad 
crash.

The changes I coded only provided a minimal speed-up since they were 
within the context of the cross-platform calls.  What they did was to cache 
the ATSUI measurements of each GetWidth call.

If the current minimum OS requirements provide it, two better calls to use 
now would be ATSUGlyphGetScreenMetrics (only on 9.1 and later) and 
ATSUGetGlyphBounds (only on 8.6 and later).  If these APIs are in the 
underlying system, they should provide the needed functionality to 
increase the performance as desired.

Comment 15

[Simon Fraser [no longer active]]

Attachment 75538 [details] [diff] in bug 121540 contains an implementation of the GetWidth
optimization for Mac QuickDraw, and ATSUI. In my tests, this gave us a pageload
boost of about 5%.

Comment 16

[Simon Fraser [no longer active]]

To 1.1

Comment 17

[Simon Paquet [:sipaq]]

This bug is targeted at a Mac classic platform/OS, which is no longer supported
by mozilla.org. Please re-target it to another platform/OS if this bug applies
there as well or resolve this bug.

I will resolve this bug as WONTFIX in four weeks if no action has been taken.
To filter this and similar messages out, please filter for "mac_cla_reorg".

Comment 18

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Roc, is this done?

Comment 19

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pretty much, yeah. I'll mark it FIXED.