361560 - Weekly layout: Sunday of previous week displayed in current week

Status: VERIFIED FIXED

(Calendar :: Printing, defect)

Description

[Stefan Sitter [:ssitter]]

Weekly layout: Sunday of previous week displayed in current week

Steps to Reproduce:
1. Start Sunbird with clean profile
2. Set First day of the week to Monday
3. Select 'File -> Print...' and choose the 'Weekly Planner layout
4. Check preview

Actual Results:
Output shows Monday 20-Nov-2006 to Saturday 25-Nov-2006 followed by Sunday 19-Nov-2006. The next week shows Monday 27-Nov-2006 to Saturday 02-Dec-2006 followed by Sunday 26-Nov-2006.

Expected Results:
Output shows Monday 20-Nov-2006 to Sunday 26-Nov-2006 in chronological order.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061122 Calendar/0.4a1 - Build ID: 2006112207

Comment 1

[Joey Minta]

Attachment: pay attention to prefs

This patch makes us pay attention to the default starting day of the week.  We have to be a bit careful, because the format is hardcoded to start with monday, but using .weekday rather than i should be sufficient to do that.

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 246546 [details] [diff] [review]
pay attention to prefs

r=lilmatt

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 246546 [details] [diff] [review]
pay attention to prefs

r2=mvl

Comment 4

[Joey Minta]

patch checked in.

Comment 5

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061207 Calendar/0.4a1

Comment 6

[Stefan Sitter [:ssitter]]

This only works for the first week being shown. For the second and following weeks this fails worse than before, see Bug 361565 Comment #3 for full test results.