"Assertion failure: fp->scopeChain == parent" with watch, setter, eval

VERIFIED FIXED in mozilla1.8.1

Status

()

P2
critical
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: jruderman, Assigned: mrbkap)

Tracking

(Blocks: 1 bug, 4 keywords)

Trunk
mozilla1.8.1
PowerPC
macOS
crash, testcase, verified1.8.0.9, verified1.8.1.1
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
js> this.__defineSetter__('y', eval); this.watch('y', function () { return ""; }); y = 1;
Assertion failure: fp->scopeChain == parent, at jsfun.c:614

Seems harmless in opt.
Created attachment 246475 [details] [diff] [review]
Give the pseudo frame a scopeChain
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #246475 - Flags: review?(brendan)
Priority: -- → P2
Target Milestone: --- → mozilla1.8.1
Comment on attachment 246475 [details] [diff] [review]
Give the pseudo frame a scopeChain

This should go into 1.8.x branches.

/be
Attachment #246475 - Flags: review?(brendan)
Attachment #246475 - Flags: review+
Attachment #246475 - Flags: approval1.8.1.1?
Attachment #246475 - Flags: approval1.8.0.9?
Comment on attachment 246475 [details] [diff] [review]
Give the pseudo frame a scopeChain

approved for 1.8/1.8.0 branches, a=dveditz for drivers
Attachment #246475 - Flags: approval1.8.1.1?
Attachment #246475 - Flags: approval1.8.1.1+
Attachment #246475 - Flags: approval1.8.0.9?
Attachment #246475 - Flags: approval1.8.0.9+
1.8 branch:   new revision: 3.56.2.12; previous revision: 3.56.2.11
1.8.0 branch: new revision: 3.56.2.1.4.6; previous revision: 3.56.2.1.4.5

Leaving open for mrbkap to commit to trunk (which is closed atm for 1.9alpha).

/be
Keywords: fixed1.8.0.9, fixed1.8.1.1
Fixed everywhere now.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 6

12 years ago
Checking in regress-361571.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-361571.js,v  <--  regress-361571.js
initial revision: 1.1
done
Flags: in-testsuite+

Comment 7

12 years ago
verified fixed 20061201 1.8.0.9 windows/linux/mac*, 1.8.1.1 windows/linux/mac*, 1.9 windows/linux
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.0.9, fixed1.8.1.1 → verified1.8.0.9, verified1.8.1.1
(Reporter)

Updated

12 years ago
No longer blocks: 349611
(Reporter)

Updated

12 years ago
Blocks: 349611

Comment 8

12 years ago
catch the indirect eval exception on trunk.

/cvsroot/mozilla/js/tests/js1_5/extensions/regress-361571.js,v  <--  regress-361571.js
new revision: 1.3; previous revision: 1.2
You need to log in before you can comment on or make changes to this bug.