361576 - underlines sometimes missing or wrong thickness

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Stuart Parmenter]

On mac cairo-cocoa builds I'm seeing some underline weirdness on various sites -- looks like a rounding problem.  Some are 1px, 2px, 0.5px, 0px..

Comment 1

[Phil Ringnalda (:philor)]

*** Bug 361414 has been marked as a duplicate of this bug. ***

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

This patch "suppresses" this bug.

But the same bug sometimes happens on Windows too. I think that the layout code has a rounding problem. I'll check it in next year.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 249587 [details] [diff] [review]
Patch rv1.0

cancelling this patch.

I'll fix this bug by bug 365336.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The patch of bug 365336 fixes this bug in most fonts.
But for some fonts (e.g., Osaka-mono), this bug still can be reproduced. That is bug 365414.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 249587 [details] [diff] [review]
Patch rv1.0

Sorry. We need this patch. Because "Osaka" return zero width for the thickness of the underline.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 249587 [details] [diff] [review]
Patch rv1.0

Can you add a comment in there saying why we're doing the PR_MAX?  (maybe add this bug # in as well)

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0.1

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in, thanks.