36159 - sending unsent messages fails

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Christopher Blizzard (:blizzard)]

Trying to send unsent messages fails.  I get this javascript message:

JavaScript error:
chrome://messenger/content/widgetglue.js line 288: getIdentityForSelectedServer
is not defined

Comment 1

[lchiang]

blizzard - are you actually in the unsent folder when you access this command?

Comment 2

[Christopher Blizzard (:blizzard)]

I tried it both ways.  I always get the same error.

Comment 3

[lchiang]

esther - can you reproduce this bug?

Comment 4

[selmer (gone)]

Still happening??

Comment 5

[selmer (gone)]

Alec, looks like you created widgetGlue.js.  Please reassign or keep as 
appropriate.

Comment 6

[Alec Flett]

adding ducarroz and sspitzer, feel free to take this from me.
I'm not sure why we're trying to call this function when sending the message

Comment 7

[(not reading, please use [e-mail] instead)]

adding rhp and putterman, but I can take a look into this.

my first guess:  code has been moved around into different js files (for general
cleanup and to support stand alone message window.)

if I'm correct, it should be a one line fix.

Comment 8

[scottputterman]

I wonder if this is why 10344 has suddenly been updated to a major regression.  
My guess is that this is because of the fact that I moved getIdentityForServer 
up into mailWidgetOverlay.js and changed it to take the server you want to get 
the identity for.

Comment 9

[scottputterman]

I have a patch that fixes the js error, but sending unsent still doesn't work 
and is probably related to the other bug I mentioned.

Comment 10

[scottputterman]

Attachment: Patch to fix this bug.

Comment 11

[(not reading, please use [e-mail] instead)]

the local mail server will not have an identity.  so we have to handle that
case.

putterman, you want to take this bug?

Comment 12

[scottputterman]

I'll take the bug about the js errors because I caused that.  What do we have to 
do for the local folder case, just handle a null pointer in the send unsent 
messages code?

Comment 13

[(not reading, please use [e-mail] instead)]

putterman, once you check in your changes to fix the js error, re-assign to me,
and I'll investigate fix the unset message problem, and make sure we do the
right thing for "local folders".

Comment 14

[(not reading, please use [e-mail] instead)]

I think putterman has checked in his part of this fix, now I'll update and see 
why sending unsent messages isn't working.

Comment 15

[(not reading, please use [e-mail] instead)]

marking m17, nsbeta2

Comment 16

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 17

[(not reading, please use [e-mail] instead)]

fix in hand, but I want to test some more tomorrow, and get a review from rhp.

Comment 18

[(not reading, please use [e-mail] instead)]

fixed,  sending unsent messages now works. 

also rosetta_mailnews.h is gone

I discovered that we are not setting or heeding the X-Mozilla-News-Host header
properly, so I'll log that bug (on me) and look into it.

Comment 19

[esther]

Using build 2000-05-25 on mac and win98 and 2000-05-26 on linux this is fixed.  
Verified.