361627 - Customize toolbar dialog box is empty

Status: VERIFIED FIXED

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[-fullmetaljacket-]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a1) Gecko/20061122 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a1) Gecko/20061122 Minefield/3.0a1

customize toolbar dialog box is empty

Reproducible: Always

Steps to Reproduce:
1. right click any space at menu bar
2. select customize...
3. customize toolbar dialog box is empty

Comment 1

[-fullmetaljacket-]

Attachment: screenshot

Comment 2

[aja+bugzilla]

Confirming in build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061122 Minefield/3.0a1 ID:2006112221 [cairo]

This message occurs in the error console when customize is selected:

Error: Node cannot be used in a document other than the one in which it was created = NS_ERROR_DOM_WRONG_DOCUMENT_ERR
Source file: chrome://global/content/customizeToolbar.js
Line: 227

Comment 3

[Dão Gottwald [:dao]]

that is bug 47903. createWrapper needs to use the correct document:

http://lxr.mozilla.org/mozilla/source/toolkit/content/customizeToolbar.js#265

Comment 4

[aja+bugzilla]

Regressed some time after this nightly: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061121 Minefield/3.0a1 ID:2006112105 [cairo]

Comment 5

[aja+bugzilla]

(In reply to comment #3)
> that is bug 47903. createWrapper needs to use the correct document:
> 
> http://lxr.mozilla.org/mozilla/source/toolkit/content/customizeToolbar.js#265
> 

...which was checked in 2006-11-22 10:35

Comment 6

[-fullmetaljacket-]

(In reply to comment #5)
> (In reply to comment #3)
> > that is bug 47903. createWrapper needs to use the correct document:
> > 
> > http://lxr.mozilla.org/mozilla/source/toolkit/content/customizeToolbar.js#265
> > 
> 
> ...which was checked in 2006-11-22 10:35
> 

yes, patch for bug# 47903 landed at build 2006112211

Comment 7

[Phil Ringnalda (:philor)]

Attachment: Partial WIP

Feel *very* free to take this bug away from me - I'm just attaching fiddling.

This is the first 60% or so: it has the advantage of restoring (as far as I checked, which wasn't all of attachment 245538 [details]) function, and the disadvantage of asserting twice on opening and twice on closing about

attempt to remove an element that was never added: 'hep != nsnull && *hep != nsnull', file /home/philor/moz/mozilla/content/xul/document/src/nsElementMap.cpp, line 281

and offhand I don't know what non-element would be not-there twice, though I'm suspicious of the badness in toolbar.xml, and wondering whether my mail/ version that unwraps before it passes through there will fare better.

Comment 8

[Steve England [:stevee]]

*** Bug 361669 has been marked as a duplicate of this bug. ***

Comment 9

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Sorry, my mistake, the assertions aren't new (Gavin had a 20061018 debug build, where they already were) and aren't this bug (they would appear to be bug 330010, since they come from removing the template-built bookmark items on the bookmarks toolbar). So, a little adoption and we're done here, until we get infrastructure to be able to do a testcase for this.

Comment 10

[Asaf Romano (gone)]

Comment on attachment 246491 [details] [diff] [review]
Fix v.1

r=mano, thanks phil.

Comment 11

[Phil Ringnalda (:philor)]

toolkit/content/customizeToolbar.js 1.32

Comment 12

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061124 Minefield/3.0a1 ID:2006112415 [cairo]

VERIFIED