361657 - NS_ERROR_DOM_WRONG_DOCUMENT_ERR in output window

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

Since bug 47903 landed, the output window is empty and there are NS_ERROR_DOM_WRONG_DOCUMENT_ERR errors in the console. This is because the code relied on Mozilla's (sane IMHO) lack of caring about the creating document.

Fix is to call importNode gratuitously.

Comment 1

[James Ross]

Attachment: importNode before appending

These are the only places I could find, and things certainly look to work after.

Comment 2

[Peter Van der Beken [:peterv]]

I'd use adoptNode instead of importNode, avoids creating a new node.

Comment 3

[:Gijs (he/him)]

Umm, but unfortunately we don't have the luxury of just working on trunk, so we can't do that, given adoptNode was implemented mere months ago.

Comment 4

[James Ross]

Attachment: adoptNode with fallback action

Since adoptNode was implemented prior to the DOM error problem, we can fall back to a no-op function. If the error is one of two known ones, we speed up the code path directly; any unknown error still acts as a no-op but with error logging.

Comment 5

[James Ross]

Checked in --> FIXED.