361683 - Help buttons missing for mailnews items in suiterunner builds

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Mark Banner (:standard8)]

The changes in bug 256915 only applied to xpfe SeaMonkey, not toolkit SeaMonkey.

We need to do some similar changes to get help buttons back in suiterunner builds.

Comment 1

[Mark Banner (:standard8)]

Attachment: Patch v1

This gets the mailnews help buttons working in suiterunner. The original helpMessengerOverlay.xul exists in /extensions/help/resources/content. As its not been changed since it was checked in, I'm proposing we just commit it afresh rather than cvs copy.

I've also included some changes to helpMessengerOverlay.xul and helpSecurityOverlay.xul to include the suitehelp.rdf chrome link in the openHelp calls (which is part of bug 346605 - but whilst I'm here..). As these two files are in chrome://communicator... and not chrome://help... it won't affect xpfe builds.

Comment 2

[Robert Kaiser]

This probably should done the same way like I fixed helpSecurityOverlay.xul stuff in attachment 242167 [details] [diff] [review] (bug 344243)

Comment 3

[Robert Kaiser]

... and this patch is almost, that.

Look at the setHelpFileURI() call I used though, it could help to simplify some calls to the help viewer by not needing the URI parameter on every openHelp() call if multiple such calls are within one file.

Comment 4

[Mark Banner (:standard8)]

Attachment: Patch v2

I didn't actually need the helpSecurityOverlay.xul changes - I hadn't spotted the setHelpFileURI in there. I don't think its worth doing that for helpMessengerOverlay.xul as there's only two direct calls in there.

Comment 5

[Ian Neal]

Is this supposed to add a help but to Mail & Newsgroup Account Settings page too? (OK and cancel buttons are also in the wrong order but I expect that is a separate bug).
I did see help buttons on Search Messages/Addresses and Message Filters, could not see anywhere else where buttons should be.

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> Is this supposed to add a help but to Mail & Newsgroup Account Settings page
> too? (OK and cancel buttons are also in the wrong order but I expect that is a
> separate bug).

The OK and cancel buttons are a separate bug due to using toolkit (intentionally implemented by FF/TB). I've not spoken to Neil to find out if we should be fixing it or not

> I did see help buttons on Search Messages/Addresses and Message Filters, could
> not see anywhere else where buttons should be.

I'll pull out the full list later.

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #6)
> > I did see help buttons on Search Messages/Addresses and Message Filters, could
> > not see anywhere else where buttons should be.
> I'll pull out the full list later.

The dialogs are:

- Preferences -> Mailnews -> Addressing -> Edit Directories
- Properties of an LDAP address book
- Account Manager
- Filter Editor (Tools -> Filters)
- Junk Mail Info
- File -> Offline -> Work Offline
- Newsgroup -> Subscribe
- View -> Views -> Custom Views? (List Dialog & Setup Dialog)
- Compose a new message, then Message -> Security Information
- Read a message, the Message -> Security Information

Hopefully most of these are the approximately correct dialogs/names. I need to check why this didn't add a button onto the account manager (if it should). 

Comment 8

[Mark Banner (:standard8)]

(In reply to comment #5)
> Is this supposed to add a help but to Mail & Newsgroup Account Settings page
> too? (OK and cancel buttons are also in the wrong order but I expect that is a
> separate bug).

I get a help button on the Mail & Newsgroup Account Settings window just under "Remove Account".

Comment 9

[Ian Neal]

(In reply to comment #7)
> The dialogs are:
> 
> - Preferences -> Mailnews -> Addressing -> Edit Directories
Yes
> - Properties of an LDAP address book
Yes
> - Account Manager
Yes
> - Filter Editor (Tools -> Filters)
Yes
> - Junk Mail Info
Yes
> - File -> Offline -> Work Offline
No but not one on non-suiterunner.
> - Newsgroup -> Subscribe
Yes
> - View -> Views -> Custom Views? (List Dialog & Setup Dialog) - Customize...
List Dialog - Yes, Setup Dialog - No (but not one on non-suiterunner)
> - Compose a new message, then Message -> Security Information
Yes (under View not Message)
> - Read a message, the Message -> Security Information
Yes (under View not Message)

Comment 10

[Ian Neal]

Should some of the help buttons only be giving a blank help window?

Comment 11

[Mark Banner (:standard8)]

(In reply to comment #10)
> Should some of the help buttons only be giving a blank help window?
> 
Yes, bug 346605 will fix those once we complete the transition to toolkit. If we fixed it now, we'd break xpfe builds.

Comment 12

[Mark Banner (:standard8)]

(In reply to comment #9)
> (In reply to comment #7)
> > The dialogs are:
> > - File -> Offline -> Work Offline
> No but not one on non-suiterunner.

Ok, I got this one wrong. It's actually (imap or newsgroup account required):

Edit -> Mail & Newsgroup Account Settings -> Offline & Disk Space -> Select Folders For Offline Use.

The dialog title is "Items for Offline Use".

Comment 13

[Mark Banner (:standard8)]

Patch checked into trunk. Note that until bug 346605 is fixed some of the buttons will just give a blank help window.