Closed
Bug 361914
Opened 18 years ago
Closed 18 years ago
hostmasks should not be formatted as mailto urls
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: sdaugherty, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [cz-0.9.78])
Attachments
(2 files)
10.11 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
11.35 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0 Host masks on IRC rarely if ever correspond to email addresses. The formatting preference to hyper link text that looks like an email address should only apply to text that's likely to contain an email address, and not to server responses that will contain only host masks. This functionality makes it harder to copy and paste host masks in the default client configuration. Reproducible: Always
Assignee | ||
Comment 1•18 years ago
|
||
Marking as blocking for some bugs that need updated patches when this gets in.
Assignee | ||
Comment 2•18 years ago
|
||
Disables mailto munging by default, enabling for echo, msg, notice, ctcp-action, topic (because the topic might contain mailto's).
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #248649 -
Flags: review?(silver)
Comment 3•18 years ago
|
||
Comment on attachment 248649 [details] [diff] [review] Patch > munger.addRule ("mailto", > /(?:\s|\W|^)((mailto:)?[^<>\[\]()\'\"\s\u201d]+@[^.<>\[\]()\'\"\s\u201d]+\.[^<>\[\]()\'\"\s\u201d]+)/i, >- insertMailToLink); >+ insertMailToLink, false); This wont work as you intend; the code at the end of initMunger enables it from the pref straight away. You probably want to rename the rule to ".mailto". r=silver with that.
Attachment #248649 -
Flags: review?(silver) → review+
Assignee | ||
Comment 4•18 years ago
|
||
Patch for checkin. Note that I've also did the whole munger entry disable stuff in output-window.js, so the channel header always gets updated correctly
Assignee | ||
Comment 5•18 years ago
|
||
Checked in --> FIXED
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Whiteboard: [cz-0.9.78]
Reporter | ||
Comment 6•18 years ago
|
||
Latest nightly seems to work correctly.
Assignee | ||
Comment 7•18 years ago
|
||
(In reply to comment #6) > Latest nightly seems to work correctly. --> VERIFIED
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 8•18 years ago
|
||
This change has regressed multiline sends, because this line: client.currentObject.dispatch("say " + msg); fails for multiline messages because the commands get split onto lines which don't have a command, which fails to work. The proper way to do this is: client.currentObject.dispatch("say", {message: msg}); which fixes the regression. That fix has been checked in with r+ from Silver on IRC.
You need to log in
before you can comment on or make changes to this bug.
Description
•