361992 - Talkback missing from Firefox trunk Mac builds

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[Robert Helmer [:rhelmer]]

Talkback no longer builds due to a change in rules.mk, since export:: as well as the talkback-specific Makefile both use the DIRS variable for different purposes.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: rename DIRS to BRANDING_DIRS

Comment 2

[Robert Helmer [:rhelmer]]

tested and landed, thanks!

Checking in Makefile.in;
/mofo/talkback/fullsoft/runtime/mac_osx/Makefile.in,v  <--  Makefile.in
new revision: 1.6; previous revision: 1.5
done

Comment 3

[Robert Helmer [:rhelmer]]

verified that talkback is in the latest MAR and DMG:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1164748080.1268.gz
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2006-11-28-13-trunk/

Build log looks good. I will leave this as FIXED until it's been independently verified.

Comment 4

[Jay Patel [:jay]]

I just installed the latest nightly build and all the Talkback files were present.  However, I am running on Intel Mac, so not sure if I can really help test this.  I did try running in Rosetta and attempted to crash, but no luck so far.  Will try later if I have time or if anyone finds me a reproducible testcase. :-)

Comment 5

[Mark Mentovai]

Talkback disables itself under Rosetta purposely, and for good reason: it would crash if it didn't.  Sorry, Jay, real ppc required here.

Comment 6

[Jay Patel [:jay]]

cc'ing a couple of QA folks that might be able to help verify this.  If not, we can keep an eye out for fresh Talkback data to see if we start getting crashes on the Trunk for Mac PPC (there aren't any now obviously, but hopefully nightly testers start reporting them soon).

Marcia/Juan:  Can you try a new Trunk/1.9 nightly build on Mac PPC and see if you can submit a Talkback incident?

Comment 7

[timeless]

TB26644728K

Comment 8

[timeless]

vrfy fixed (talkback server still has 1 red frame, jay still owes me a fix)