362000 - AUS feature in Preferences window needs to make &brandShortName; localizable

Status: RESOLVED FIXED

(Calendar :: Preferences, defect)

Description

[Cédric Corazza]

Bug 341971 landed the AUS feature in Sunbird, but unlike Firefox or Thunderbird Preferences > Advanced > Update Tab, &brandShortName; is not localizable (hardcoded in xul file).
A quick search in lxr showed that at least for the moment, cs, fi, lt and pl locales need that :
http://lxr.mozilla.org/l10n-mozilla1.8/search?string=enableAppUpdate.label

Comment 1

[Stefan Sitter [:ssitter]]

According to Bug 341971 Comment #16 this was done on purpose. Entity brandShortName is already defined in
 /calendar/locales/en-US/chrome/branding/brand.dtd
 /other-licenses/branding/sunbird/locales/en-US/brand.dtd
so why is this not localizable?

Comment 2

[Cédric Corazza]

(In reply to comment #1)
> According to Bug 341971 Comment #16 this was done on purpose. Entity
> brandShortName is already defined in
>  /calendar/locales/en-US/chrome/branding/brand.dtd
>  /other-licenses/branding/sunbird/locales/en-US/brand.dtd
> so why is this not localizable?
> 

I wasn't clear :
entity brandShortName in pl locale for browser for instance :

http://lxr.mozilla.org/l10n-mozilla1.8/source/pl/browser/chrome/branding/brand.dtd
http://lxr.mozilla.org/l10n-mozilla1.8/source/pl/other-licenses/branding/firefox/brand.dtd

is translated differently in 

http://lxr.mozilla.org/l10n-mozilla1.8/source/pl/browser/chrome/browser/preferences/advanced.dtd#55

So I guess it will be the same for Calendar. That's why this line in advanced.xul :

http://lxr.mozilla.org/mozilla1.8/source/calendar/base/content/preferences/advanced.xul#168

should be replaced by

label="&pref.calendar.advanced.update.enableAppUpdate.label;"

and added in 

chrome/calendar/preferences/advanced.dtd 

I hope this was clearer

Comment 3

[Marek Stępień [:marcoos, inactive]]

To make it more clear, you can't just do sth like this:

 &checkForUpdatesFor;
 * &brandShortName;

as the brandShortName may not be all you would need in some languages, i.e. it may need to be declensed, like in Polish:

 Sprawdz dostepnosc aktualizacji dla:
 * programu Sunbird

This is not a real declension of the Sunbird name, as we are using a helper word here, since you can't really automate the declension of the entities.

So, we really need to add the word "programu" before the brand short name. This applies to many more languages.

Comment 4

[Matthew (lilmatt) Willis]

Attachment: rev0 - Adds entity for appname

Readds the entity.

Comment 5

[Joey Minta]

Comment on attachment 246743 [details] [diff] [review]
rev0 - Adds entity for appname

r=jminta

Comment 6

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED