Closed
Bug 362255
Opened 19 years ago
Closed 16 years ago
Support large files (>= 2GB) on OpenBSD.
Categories
(NSPR :: NSPR, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
4.8.5
People
(Reporter: wtc, Assigned: wtc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
555 bytes,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
NSPR should support large files (>= 2GB) on OpenBSD.
This requires defining the appropriate macro (_PR_HAVE_LARGE_OFF_T
or _PR_HAVE_OFF64_T) instead of _PR_NO_LARGE_FILES in
mozilla/nsprpub/pr/include/md/_openbsd.h.
|
||
Updated•19 years ago
|
QA Contact: wtchang → nspr
|
||
Comment 1•16 years ago
|
||
OpenBSD should use _PR_HAVE_LARGE_OFF_T because sizeof(off_t) is 8 even if 32bit.
|
|
||
Updated•16 years ago
|
Attachment #442038 -
Flags: review?(wtc)
|
Assignee | |
Comment 2•16 years ago
|
||
Comment on attachment 442038 [details] [diff] [review]
patch
r=wtc. Thanks for the patch.
I checked it in on the NSPR trunk (NSPR 4.8.5).
Checking in _openbsd.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_openbsd.h,v <-- _openbsd.h
new revision: 3.10; previous revision: 3.9
done
Attachment #442038 -
Flags: review?(wtc) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Makoto, should we apply the same patch to _netbsd.h?
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.8.5
|
|
||
Comment 4•16 years ago
|
||
(In reply to comment #3)
> Makoto, should we apply the same patch to _netbsd.h?
Yes. BSD 4.4 defines sizeof(off_t) == 8.
You need to log in
before you can comment on or make changes to this bug.
Description
•