362289 - Use contents of Sender: header field as envelope sender if it exists

Status: NEW

(Bugzilla :: Email Notifications, enhancement, P4)

Description

[Magnus Holmgren]

User-Agent:       Opera/9.02 (X11; Linux i686; U; en)
Build Identifier: 

MessageToMTA() currently uses the contents of the From: header field as the envelope sender (sendmail -f parameter). It would be better if the Sender: field were used if it exists, so that mail is sent with an appropriate return address, should the admin wish to modify the newchangedemail notification template to put the changed in the From: field and Param('mailfrom') in Sender:, just to take an example (bug 126151).

Reproducible: Always




Unfortunately Email::Send::SMTP likewise takes the envelope sender from the From: field as of version 2.181, and it can't be overridden. That's OK in a MUA, but not in this case.

Comment 1

[Max Kanat-Alexander]

Upstream Bugzilla doesn't include any "Sender" headers, so at this point we're unlikely to fix this here. 

In general, we don't add code to handle things that we don't actually do.

However, if we ever do add any Sender headers, this would make sense.

Comment 2

[Magnus Holmgren]

I'm sorry but I don't understand your reasoning. Bugzilla *can* include "Sender:" fields, it just doesn't do it in a default installation. Once again, templates *are* supposed to be customized, aren't they? Though it was easier before, when newchangedmail was simply a parameter.

What do you mean "Upstream Bugzilla"? Do you mean that you're only ever going to add features that you planning to use here at bugzilla.mozilla.org? I certainly don't hope so, and I honestly don't think so either. As a prominent example, bugs.kde.org sets From: to the changer and Sender: to [e-mail].

So, considering that the fix is one line (at least for the Sendmail method) and unobtrusive, and that people actually use it, will you please leave it open or at most mark it LATER?

Comment 3

[Olav Vitters]

I think this makes sense. Although it will be very low priority (patches welcome;).

Comment 4

[Max Kanat-Alexander]

Okay. Going along with Olav on that.