The xslt-param code doesn't initialize recycler

RESOLVED FIXED

Status

()

Core
XSLT
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: sicking, Assigned: sicking)

Tracking

({fixed1.8.1.1})

Trunk
fixed1.8.1.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The code that evaluates xslt-param XPath expressions doesn't initialize it's txExprResult recycler. This means that some expressions will crash with a null-pointer deref.
Created attachment 247006 [details] [diff] [review]
Patch to fix

This was already reviewed by peterv as part of bug 361442
Attachment #247006 - Flags: superreview+
Attachment #247006 - Flags: review+
Attachment #247006 - Flags: approval1.8.1.1?
Attachment #247006 - Flags: approval1.8.0.9?
This should be a very safe patch with extremely low risk and fixes a new feature in FF2 (xslt parameters)
Attachment #247006 - Flags: approval1.8.0.9?
Comment on attachment 247006 [details] [diff] [review]
Patch to fix

approved for 1.8 branch, a=dveditz
Attachment #247006 - Flags: approval1.8.1.1? → approval1.8.1.1+
Summary: The xslt-param code doesn't initialize recykler → The xslt-param code doesn't initialize recycler
Keywords: fixed1.8.1.1
Depends on: 361442
Checked in to trunk too
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Removing dependency since I checked in the code here instead.
No longer depends on: 361442
You need to log in before you can comment on or make changes to this bug.