Closed
Bug 362297
Opened 19 years ago
Closed 19 years ago
The xslt-param code doesn't initialize recycler
Categories
(Core :: XSLT, defect)
Core
XSLT
Tracking
()
RESOLVED
FIXED
People
(Reporter: sicking, Assigned: sicking)
Details
(Keywords: fixed1.8.1.1)
Attachments
(1 file)
|
1.14 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
dveditz
:
approval1.8.1.1+
|
Details | Diff | Splinter Review |
The code that evaluates xslt-param XPath expressions doesn't initialize it's txExprResult recycler. This means that some expressions will crash with a null-pointer deref.
|
Assignee | |
Comment 1•19 years ago
|
||
This was already reviewed by peterv as part of bug 361442
Attachment #247006 -
Flags: superreview+
Attachment #247006 -
Flags: review+
Attachment #247006 -
Flags: approval1.8.1.1?
Attachment #247006 -
Flags: approval1.8.0.9?
|
|
Assignee | |
Comment 2•19 years ago
|
||
This should be a very safe patch with extremely low risk and fixes a new feature in FF2 (xslt parameters)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #247006 -
Flags: approval1.8.0.9?
|
||
Comment 3•19 years ago
|
||
Comment on attachment 247006 [details] [diff] [review]
Patch to fix
approved for 1.8 branch, a=dveditz
Attachment #247006 -
Flags: approval1.8.1.1? → approval1.8.1.1+
|
|
Assignee | |
Updated•19 years ago
|
Summary: The xslt-param code doesn't initialize recykler → The xslt-param code doesn't initialize recycler
|
|
Assignee | |
Updated•19 years ago
|
Keywords: fixed1.8.1.1
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checked in to trunk too
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•19 years ago
|
||
Removing dependency since I checked in the code here instead.
No longer depends on: 361442
You need to log in
before you can comment on or make changes to this bug.
Description
•