362348 - Crash [@ nsTableRowFrame::CollapseRowIfNecessary] on print preview with testcase, using display: table-footer-group; visibility: collapse;

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase, which crashes current trunk (and reflow branch) builds when in print preview.

Talkback ID: TB26690522K
nsTableRowFrame::CollapseRowIfNecessary  [mozilla\layout\tables\nstablerowframe.cpp, line 1604]
nsTableRowGroupFrame::CollapseRowGroupIfNecessary  [mozilla\layout\tables\nstablerowgroupframe.cpp, line 873]
nsTableFrame::AdjustForCollapsingRowsCols  [mozilla\layout\tables\nstableframe.cpp, line 2421]
nsTableFrame::Reflow  [mozilla\layout\tables\nstableframe.cpp, line 2160]
nsContainerFrame::ReflowChild  [mozilla\layout\generic\nscontainerframe.cpp, line 742]
nsTableOuterFrame::OuterReflowChild  [mozilla\layout\tables\nstableouterframe.cpp, line 1302]
0x0296bb08

This seems like a regression, it doesn't crash on branch builds.
It doesn't crash with a 2006-03-01 build, it crashes with a 2006-03-05 build, I think it's a regression from bug 326551.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: backtrace from a debug reflow branch build

Comment 3

[Bernd]

The testcase triggers the assert at http://lxr.mozilla.org/seamonkey/source/layout/tables/nsTableFrame.cpp#555

which describes exactly the problem we are running in.

Comment 4

[Bernd]

Attachment: patch

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Actually, make that an NS_STATIC_CAST

Comment 6

[Bernd]

fixed,  testcase checked in into the table printing rtest dir.

Comment 7

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061208
The testcase crashes Mozilla when closing print preview, but
that's because the reflow branch has landed and has been filed as bug 362210.