Last Comment Bug 362391 - DOMAttrModified doesn't handle namespaced attributes properly
: DOMAttrModified doesn't handle namespaced attributes properly
Status: RESOLVED FIXED
: testcase
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug] (vacation Aug 25-28)
: Hixie (not reading bugmail)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-11-30 13:22 PST by Olli Pettay [:smaug] (vacation Aug 25-28)
Modified: 2006-12-03 15:05 PST (History)
2 users (show)
bugs: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (1.71 KB, application/xhtml+xml)
2006-11-30 13:23 PST, Olli Pettay [:smaug] (vacation Aug 25-28)
no flags Details
proposed patch (3.17 KB, patch)
2006-11-30 13:32 PST, Olli Pettay [:smaug] (vacation Aug 25-28)
jonas: review+
jonas: superreview+
Details | Diff | Splinter Review
mochitest (3.42 KB, patch)
2006-12-01 01:19 PST, Olli Pettay [:smaug] (vacation Aug 25-28)
jonas: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] (vacation Aug 25-28) 2006-11-30 13:22:45 PST
a testcase and patch coming.
Comment 1 Olli Pettay [:smaug] (vacation Aug 25-28) 2006-11-30 13:23:15 PST
Created attachment 247095 [details]
testcase
Comment 2 Olli Pettay [:smaug] (vacation Aug 25-28) 2006-11-30 13:23:54 PST
Comment on attachment 247095 [details]
testcase

All tests should be true
Comment 3 Olli Pettay [:smaug] (vacation Aug 25-28) 2006-11-30 13:32:52 PST
Created attachment 247096 [details] [diff] [review]
proposed patch

Keeping things simple for now.
If dispatching DOMAttrModified shows in profiles, we could add a method to get attr node using PRInt32 and nsIAtom*.
Comment 4 Adam Guthrie 2006-12-01 00:03:38 PST
We should "mochify" those tests.
Comment 5 Olli Pettay [:smaug] (vacation Aug 25-28) 2006-12-01 00:47:06 PST
Patch checked in.
Testcase needs mochifying.
Comment 6 Olli Pettay [:smaug] (vacation Aug 25-28) 2006-12-01 01:19:09 PST
Created attachment 247162 [details] [diff] [review]
mochitest
Comment 7 Olli Pettay [:smaug] (vacation Aug 25-28) 2006-12-01 01:40:37 PST
Comment on attachment 247162 [details] [diff] [review]
mochitest

Not sure if mochitests need reviews

Note You need to log in before you can comment on or make changes to this bug.