DOMAttrModified doesn't handle namespaced attributes properly

RESOLVED FIXED

Status

()

Core
DOM: Events
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

({testcase})

Trunk
testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

11 years ago
a testcase and patch coming.
(Assignee)

Comment 1

11 years ago
Created attachment 247095 [details]
testcase
(Assignee)

Comment 2

11 years ago
Comment on attachment 247095 [details]
testcase

All tests should be true
(Assignee)

Comment 3

11 years ago
Created attachment 247096 [details] [diff] [review]
proposed patch

Keeping things simple for now.
If dispatching DOMAttrModified shows in profiles, we could add a method to get attr node using PRInt32 and nsIAtom*.
Attachment #247096 - Flags: superreview?(bugmail)
Attachment #247096 - Flags: review?(bugmail)
Attachment #247096 - Flags: superreview?(bugmail)
Attachment #247096 - Flags: superreview+
Attachment #247096 - Flags: review?(bugmail)
Attachment #247096 - Flags: review+

Comment 4

11 years ago
We should "mochify" those tests.
Flags: in-testsuite?
Keywords: testcase
(Assignee)

Comment 5

11 years ago
Patch checked in.
Testcase needs mochifying.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

11 years ago
Created attachment 247162 [details] [diff] [review]
mochitest
(Assignee)

Comment 7

11 years ago
Comment on attachment 247162 [details] [diff] [review]
mochitest

Not sure if mochitests need reviews
Attachment #247162 - Flags: review?(bugmail)
Attachment #247162 - Flags: review?(bugmail) → review+
(Assignee)

Updated

11 years ago
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.