Closed Bug 362655 Opened 18 years ago Closed 18 years ago

Make "Keyboard Shortcuts" menu item pointing to online documentation

Categories

(Camino Graveyard :: Toolbars & Menus, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: froodian, Assigned: froodian)

Details

(Keywords: fixed1.8.1.2)

Attachments

(2 files)

3.38 KB, patch
bugzilla-graveyard
: review+
stuart.morgan+bugzilla
: superreview+
Details | Diff | Splinter Review
26.09 KB, application/zip
Details
Some apps have a "Keyboard Shortcuts" menu item in the help menu (Safari, iCal, iTunes, NNW).  Since we're growing alternate and non-menu item shortcuts, I think this would be a useful addition to our menus.  The help menu currently has only three items, so I certainly don't think it would be menu overload.  We should consider doing this.
I also think this would be a very good idea.
We should discuss this at some point.  If we do want to do it for 1.1, it'll need to be done before b1.
Confirming, per pink in status meeting.
Assignee: nobody → stridey
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: camino1.1b1?
Target Milestone: --- → Camino1.1
Attached patch PatchSplinter Review
This will need a m.o redirect to http://www.caminobrowser.org/support/docs/shortcuts/ and an addition to WebsiteDefaults.strings to have "KeyboardShortcutsPageDefault" point to it.

I also ripped out the three unused help menu items - it doesn't look like they'll be added back any time soon, and if we ever do add them back they'd be trivially easy to rewrite.
Attachment #251828 - Flags: review?(bugzilla)
Attached file New MainMenu.nib
Nib to go along
Comment on attachment 251828 [details] [diff] [review]
Patch

r=me on the code; didn't test or check the nib, but I trust that it's right.
Attachment #251828 - Flags: review?(bugzilla) → review+
Attachment #251828 - Flags: superreview?(stuart.morgan)
I suggest the m.o url
http://www.mozilla.org/projects/camino/shortcuts.html

We also need to clean up the cruft in WebsiteDefaults.strings when we land this.
Comment on attachment 251828 [details] [diff] [review]
Patch

sr=smorgan for this and the appropriate strings changes.
Attachment #251828 - Flags: superreview?(stuart.morgan) → superreview+
Checked in on trunk and MOZILLA_1_8_BRANCH.  We should make sure we extra-polish that page, now that it's linked to in-app.
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: camino1.1b1?
Keywords: fixed1.8.1.2
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: