The default bug view has changed. See this FAQ.

Branch builds on modern linux will use system cairo unintentionally

RESOLVED FIXED

Status

Core Graveyard
GFX
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: tor, Assigned: tor)

Tracking

({fixed1.8.0.10, fixed1.8.1.2})

1.8 Branch
x86
Linux
fixed1.8.0.10, fixed1.8.1.2

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(5 attachments)

(Assignee)

Description

10 years ago
On a modern linux system, the linker seems to use cairo symbols in the system libcairo (already loaded due to gtk dependence) instead of those in libmozcairo.  As the API was still somewhat in flux at the time we took a snapshot of cairo for the branch, this causes some odd behavior.  One example I know of is the pad mode for gradients, illustrated by the test URL.

The trunk renames the cairo and libpixman symbols to avoid this, but the change was never ported to the branch.
(Assignee)

Comment 1

10 years ago
Created attachment 247565 [details] [diff] [review]
rename cairo
Attachment #247565 - Flags: review?(vladimir)
Comment on attachment 247565 [details] [diff] [review]
rename cairo

This should be fine and low-risk; I assume you re-ran the awk thing to regenerate the remap, since it's an older version of cairo on the branch?
Attachment #247565 - Flags: review?(vladimir) → review+
(Assignee)

Comment 3

10 years ago
It's actually a new awk script - the older cairo we're using on the branch does have api tags like the current one.
(Assignee)

Updated

10 years ago
Attachment #247565 - Flags: approval1.8.1.2?
Attachment #247565 - Flags: approval1.8.0.9?

Comment 4

10 years ago
Comment on attachment 247565 [details] [diff] [review]
rename cairo

Approved for both branches, a=jay for drivers.
Attachment #247565 - Flags: approval1.8.1.2?
Attachment #247565 - Flags: approval1.8.1.2+
Attachment #247565 - Flags: approval1.8.0.9?
Attachment #247565 - Flags: approval1.8.0.10+
(Assignee)

Comment 5

10 years ago
Checked in on MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1.2
(Assignee)

Comment 6

10 years ago
Checked in on MOZILLA_1_8_0_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.0.10
Resolution: --- → FIXED

Comment 7

10 years ago
Hi T Rowley,
I was comparing the 1_8 and 1_8_1 branches on Fedora 6, and the test URL's seem exactly identical.  There doesnt seem to be any "odd behavior" from the screenshots that i took of the pad mode.  Can you elaborate more on what exactly needs to be tested to verify your patch?

The builds i used are:
FF 2.0.0.1: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061208 Firefox/2.0.0.1

FF 2.0.0.2 RC1: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2) Gecko/20070208 Firefox/2.0.0.2

FF 1.5.0.9: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.9) Gecko/20061206 Firefox/1.5.0.9

FF1.5.0.10 RC1: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.10) Gecko/20070208 Firefox/1.5.0.10

Screenshots are attached.  

If you can verify the patch easily on the 1_8 branch, please feel free to and comment back in this bug by changing the keywords to "verified1.8.1.2, verified1.8.0.10"

Comment 8

10 years ago
Created attachment 254600 [details]
FF1509 TestURL Screenshot

Comment 9

10 years ago
Created attachment 254601 [details]
FF1510 TestURL Screenshot

Comment 10

10 years ago
Created attachment 254602 [details]
FF2001 TestURL Screenshot

Comment 11

10 years ago
Created attachment 254603 [details]
FF2002 TestURL Screenshot
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.