Closed Bug 362868 Opened 15 years ago Closed 15 years ago

Branch builds on modern linux will use system cairo unintentionally

Categories

(Core Graveyard :: GFX, defect)

1.8 Branch
x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tor, Assigned: tor)

References

()

Details

(Keywords: fixed1.8.0.10, fixed1.8.1.2)

Attachments

(5 files)

On a modern linux system, the linker seems to use cairo symbols in the system libcairo (already loaded due to gtk dependence) instead of those in libmozcairo.  As the API was still somewhat in flux at the time we took a snapshot of cairo for the branch, this causes some odd behavior.  One example I know of is the pad mode for gradients, illustrated by the test URL.

The trunk renames the cairo and libpixman symbols to avoid this, but the change was never ported to the branch.
Attached patch rename cairoSplinter Review
Attachment #247565 - Flags: review?(vladimir)
Comment on attachment 247565 [details] [diff] [review]
rename cairo

This should be fine and low-risk; I assume you re-ran the awk thing to regenerate the remap, since it's an older version of cairo on the branch?
Attachment #247565 - Flags: review?(vladimir) → review+
It's actually a new awk script - the older cairo we're using on the branch does have api tags like the current one.
Attachment #247565 - Flags: approval1.8.1.2?
Attachment #247565 - Flags: approval1.8.0.9?
Comment on attachment 247565 [details] [diff] [review]
rename cairo

Approved for both branches, a=jay for drivers.
Attachment #247565 - Flags: approval1.8.1.2?
Attachment #247565 - Flags: approval1.8.1.2+
Attachment #247565 - Flags: approval1.8.0.9?
Attachment #247565 - Flags: approval1.8.0.10+
Checked in on MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1.2
Checked in on MOZILLA_1_8_0_BRANCH.
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8.0.10
Resolution: --- → FIXED
Hi T Rowley,
I was comparing the 1_8 and 1_8_1 branches on Fedora 6, and the test URL's seem exactly identical.  There doesnt seem to be any "odd behavior" from the screenshots that i took of the pad mode.  Can you elaborate more on what exactly needs to be tested to verify your patch?

The builds i used are:
FF 2.0.0.1: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061208 Firefox/2.0.0.1

FF 2.0.0.2 RC1: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2) Gecko/20070208 Firefox/2.0.0.2

FF 1.5.0.9: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.9) Gecko/20061206 Firefox/1.5.0.9

FF1.5.0.10 RC1: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.10) Gecko/20070208 Firefox/1.5.0.10

Screenshots are attached.  

If you can verify the patch easily on the 1_8 branch, please feel free to and comment back in this bug by changing the keywords to "verified1.8.1.2, verified1.8.0.10"
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.