362876 - after updating restart is needed but data in editing event is not saved

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061205 Calendar/0.4a1

After each software upadate restart is required, however if there is any event/task opened data is lost

Reproducible: Always

Steps to Reproduce:
1. launch sunbird
2. press "check for updates" from help menu
3. open event and start editing
4. second dialog has finished updating and application needs restart
5. let application be restarted

Actual Results:  
edited event is closed without saving data

Expected Results:  
there should be alert that there is opened event which should be closed before restarting

Comment 1

[Joey Minta]

Attachment: add tryToClose method

The updater will iterate through all open windows and look for a 'tryToClose' method.  If one exists, it'll run the method and only quit if it returns true.  This patch implements such a method in the item-dialog.

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 248030 [details] [diff] [review]
add tryToClose method

>+    return promptService.confirm(window, 
Trailing spaces on this line ^^

r=lilmatt with that, but I'd love it if we could get beltzner to massage the text.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 248030 [details] [diff] [review]
add tryToClose method

r2=mvl

Comment 4

[Joey Minta]

patch checked in.  Feel free to file a follow-up if anyone can come up with better verbage.

Comment 5

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20061225 Calendar/0.4a1