Closed
Bug 363007
Opened 19 years ago
Closed 19 years ago
Disable bookmark logging code in final 1.1 release
Categories
(Camino Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.5
People
(Reporter: alqahira, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.3)
Attachments
(1 file)
|
735 bytes,
patch
|
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
We need to remove the bookmarks logging code from the final 1.1 release so as to not spam consoles indefinitely, even if the bookmarks-eating bug isn't fixed (or at least discuss doing so).
|
Reporter | |
Updated•19 years ago
|
Flags: camino1.1?
|
|
Reporter | |
Comment 1•19 years ago
|
||
Given that it seems unlikely we'll find the cause of the bug, we should just disable it in all the 1.1.x releases and leave it in the source (and on) for pre-1.2 work and the trunk (and then spin a 1.1+logging build like we did for 1.0.3).
Summary: Remove bookmark logging code from final 1.1 release → Disable bookmark logging code in final 1.1 release
|
|
Reporter | |
Comment 2•19 years ago
|
||
We'll also want to disable the alert in bug 364496, since without the logging, it's (mostly) pointless.
|
|
Reporter | |
Comment 3•19 years ago
|
||
Ignore that last comment. Stuart told me the only thing spamming the Console right now is the size on shutdown; everything else is only triggered on failure, so we can leave that (and the alert) in.
|
Assignee | |
Comment 4•19 years ago
|
||
For landing on branch.
Assignee: nobody → stuart.morgan
Status: NEW → ASSIGNED
Attachment #254542 -
Flags: superreview?(mikepinkerton)
|
||
Comment 5•19 years ago
|
||
Comment on attachment 254542 [details] [diff] [review]
remove logging
rs=pink
Attachment #254542 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
Assignee | |
Comment 6•19 years ago
|
||
Landed on MOZILLA_1_8_BRANCH.
|
|
Reporter | |
Updated•19 years ago
|
Flags: camino1.1?
You need to log in
before you can comment on or make changes to this bug.
Description
•