363010 - Include localized/multilingual EULAs in the .dmg license agreement

Status: RESOLVED FIXED

(Camino Graveyard :: Translations, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Placeholder bug for tracking the work needed to get a multilingual EULA to display when the .dmg mounts.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Note that we will be continuing to use the v1.1 EULA for the time being, due to the issues mentioned in bug 343220 comment 15.

There are only 8 posted translations of the EULA v1.1 (the "Firefox 1.5" ones at http://www.mozilla.com/en-US/legal/eula/ ), which is only about half of the number of localizations we're shipping in 1.0.x.

Comment 2

[Stuart Morgan]

Attachment: adds 8 languages

Here's the new resource file. Notes:
- I just build a new .r file, given our timeframe. I'll look into open-sourcing the tool I used to do this so that down the road we could switch to a bunch of RTF files and some build magic.
- The translations of the chrome are all verbatim from Apple's example resource file, with the exception of fixing up the print and save buttons to use ellipses rather than '...' and nothing respectively (only in the single-byte languages, as I didn't want to mess anything up). That means that the text on the left in all the translations does *not* match the English. It's a translated version of (I assume, since this is how the English reads):
    If you agree with the tems of this license,
    press "Agree" to install the software.  If
    you do not agree, press "Disagree".
If we care, we'll need that string translated by localizers.
- I took the translated 1.5 licenses and used them with the following changes:
  1) s/MOZILLA FIREFOX/CAMINO/
  2) s/FIREFOX/CAMINO
  3) s/Corporation/Foundation/
  4) I removed the last two lines of every translation; they appeared to be translations of what "agree" and "disagree" links would be, and that didn't make any sense to include in the body.
  5) I removed the first few chunks of each translation, above the part about it not being an official document, but a translation from the official English version. The parts I removed redundantly explained that it was a software license, and if I understood correctly referred to using a navigation bar to read the entire thing, which made no sense.

I was doing 4 and 5 blind in the non-Roman languages; the structure was very regular, so I'm not worried, but probably someone should check. The exception is the Japanese version; the top of that translation has a totally different format than everything else, and since I don't speak Japanese, I have no idea why, so I left it alone.

Smokey, could you sanity check this to the best of your ability, and maybe ask localizers to take a look as well?

Comment 3

[Mark Mentovai]

Might be easier to sanity-check this if you provided a dummy disk image with this resource applied as the license file.  You can build such an image really easily by using pkg-dmg manually if you don't already have another way to do it.

Comment 4

[Stuart Morgan]

Attachment: test dmg

Sure, if you want to be all logical about it.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 262374 [details] [diff] [review]
adds 8 languages

Nit: Please use curly quotes in the "If you agree to the terms" block in Roman languages.  

Nit: We should use curly quotes in the actual license text for all the Roman languages, too; Spanish seems to be lacking them.

Nit: In the Simplified Chinese and Korean versions, only Camino is bolded in the header line that reads "Camino End User Software License Agreement".  I'm not sure how difficult this is to fix, double-byte and all that....

I'd like the www.mozilla.org/licensing url to remain (since it points to the m.o licensing policies in general), but the descriptive text accompanying that URL is pretty wrong at least in English.

If we can get l10n to translate a few strings for us in a timely manner, then I'm all for fixing that header and syncing the instructional text in the sidebar to match the English version.  If not, so be it.

Otherwise, it looks perfectly sane as far as I can tell.

r=ardissone with the nits addressed.

Comment 6

[Stuart Morgan]

Comment on attachment 262374 [details] [diff] [review]
adds 8 languages

(In reply to comment #5)
> Nit: Please use curly quotes in the "If you agree to the terms" block
> in Roman languages.

They are, if you mean the text on the chrome in the left.

> Nit: We should use curly quotes in the actual license text for all the Roman
> languages, too; Spanish seems to be lacking them.

It's copy-and-paste from the translated page, and more divergence seems bad; also, I have no idea what quotes to use for Spanish.

> Nit: In the Simplified Chinese and Korean versions, only Camino is bolded in
> the header line that reads "Camino End User Software License Agreement".

I selected and bolded the whole line each time, so apparently that's a font thing.

> I'd like the www.mozilla.org/licensing url to remain (since it points to the
> m.o licensing policies in general)

All it was there for was to point to translations; we now include the translations that were there, so I'm not sure why we need it. And if it's going to be there for some reason other than to point to translations, shouldn't it be part of the text that's actually translated into all the languages?

> If we can get l10n to translate a few strings for us in a timely manner, then
> I'm all for fixing that header and syncing the instructional text in the
> sidebar to match the English version.  If not, so be it.

We should probably check it in as is so it's of the critical path, and if localizers give us updated version we can swap them in later.

Comment 7

[Marcello Testi]

we can work on the dummy image as well. What exactly do you expect? Should we work on the .r or give back an RTF with the correct strings?

Comment 8

[Stuart Morgan]

Plain text files are fine.

Comment 9

[Mark Mentovai]

Curiosity: what dictates the order of languages in the pop-up?

Looks like the system is responsible for menu items named "zh_TW" and "zh_CN" instead of displaying appropriate localizations?

The quotes in the instructional text shouldn't just be curly, they should be language-appropriate: «…», „…‟, etc.

There's a blank line at the end of the English EULA text but no blank line at the ends of the other languages' texts.

Comment 10

[Mark Mentovai]

> All it was there for was to point to translations; we now include the
> translations that were there, so I'm not sure why we need it.

Translations added after a dmg is released?

> And if it's going
> to be there for some reason other than to point to translations, shouldn't it
> be part of the text that's actually translated into all the languages?

Oui.

Comment 11

[Stuart Morgan]

(In reply to comment #9)
> Curiosity: what dictates the order of languages in the pop-up?

DMG gnomes? Certainly nothing related to the order I have them in the resource file...

> Looks like the system is responsible for menu items named "zh_TW" and "zh_CN"
> instead of displaying appropriate localizations?

Yep, as far as I can tell the system makes everything in that menu. Having the language codes is certainly pretty ghetto.

> There's a blank line at the end of the English EULA text but no blank line at
> the ends of the other languages' texts.

I'll remove that.

So what specifically needs to change before this lands?
1) Am I adding back a link to the license, what should the text say?
2) Are we translating 1) into every language ourselves?
3) Are we really blocking on using language-specific quotes in the generic chrome text? (Is there really a point to making that change if we are expecting new translations of that?)
4) Are we not landing until the 8 new chrome strings come in?

Comment 12

[Marcello Testi]

I'm about to pass the dummy DMG to the l10n list. I think we should leave as is the text from the bolded header on. I worked on fixing the italian version through MozIta several months ago, but I don't know if those edits have ever seen the light, anyway this is a semi-official MoFo thing, so leave it alone.

I am wandering if we should work on the first paragraph before the EULA header: it has several oddities (especially when referring to "EULA") in Italian and one typo ("Moxilla", and btw does such a thing as "Mozilla Camino" exist?)

Comment 13

[Stuart Morgan]

"Mozilla Firefox" was supposed to be replaced with just "Camino"; my search-and replace missed it because of the typo. I'll fix that as well.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #11)
> > Looks like the system is responsible for menu items named "zh_TW" and "zh_CN"
> > instead of displaying appropriate localizations?
> 
> Yep, as far as I can tell the system makes everything in that menu. Having the
> language codes is certainly pretty ghetto.

Ew.  Those were correct here.

(In reply to comment #6)
> (From update of attachment 262374 [details] [diff] [review])
> (In reply to comment #5)
> > Nit: Please use curly quotes in the "If you agree to the terms" block
> > in Roman languages.
> 
> They are, if you mean the text on the chrome in the left.

I can see by .r inspection that they aren't for French, Italian, and Spanish. (\"Accepter\", \"Accetto\", \"Aceptar\")

I think we need to chat about this in the channel tomorrow and come up with a "plan" so we're not arguing back and forth via bug and sending Marcello a lot of noise ;)

Comment 15

[Mark Mentovai]

> 1) Am I adding back a link to the license, what should the text say?

You can leave the en one in, and localizers can supply translated text for other languages if the already-translated licenses don't have them.

> 3) Are we really blocking on using language-specific quotes in the generic
> chrome text? (Is there really a point to making that change if we are expecting
> new translations of that?)

It's an easy change, at least for de and fr, you can just rip the correct quotes right out of the license text.

> 4) Are we not landing until the 8 new chrome strings come in?

No, we're landing now and can revise the .r as new strings are made available.

> I think we should leave as is the text from the bolded header on.

Agree.

> Moxilla

That's what I called at least one of my unofficial test builds!

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #6)
> It's copy-and-paste from the translated page, and more divergence seems bad;
> also, I have no idea what quotes to use for Spanish.

FWIW, my bible for such things, the NeoOffice smart quote system, shows Spanish using the same smart quotes as English.

How's http://wiki.caminobrowser.org/Development:Planning:dmg_License_Localization for a summary of the tasks remaining?

Comment 17

[Mark Mentovai]

Comment on attachment 262374 [details] [diff] [review]
adds 8 languages

OK, with the small changes we discussed.

Comment 18

[Stuart Morgan]

Checken in on trunk and MOZILLA_1_8_BRANCH with:
- More quote smartness
- Less Moxilla
- English pointer to the license site
- No trailing English newline

Please file a new bug when the localized chrome strings are available, and with any issues that might be found in the translations.