363072 - [reflow branch][border-collapse] Table content unnecessarily wrapped

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Andrew Schultz]

With the reflow branch, I see text content unnecessarily wrapping in a table.  The table should be wider to accommodate the content.

Comment 1

[Andrew Schultz]

Attachment: testcase

With the reflow branch, one of the "blah" wraps to the next line, but it shouldn't.

Comment 2

[Bill Gianopoulos [:WG9s]]

Confirming on Windows OK -> ALL.

Comment 3

[Bill Gianopoulos [:WG9s]]

(In reply to comment #2)
> Confirming on Windows OK -> ALL.
> 
Hmmm.  I obviously meant OS -> ALL.

Comment 4

[Mats Palmgren (inactive)]

Attachment: Testcase #2a (Quirks mode)

Comment 5

[Mats Palmgren (inactive)]

Attachment: Testcase #2b (Standards mode)

Comment 6

[Mats Palmgren (inactive)]

Attachment: wip

This makes the layout of all the testcases the same as on trunk...

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd think |aBorder.width| should already have that size in it.

Comment 8

[Mats Palmgren (inactive)]

Attachment: wip2

It seems so.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I thought border was supposed to be the amount on the outside, fixed up in places like nsCSSOffsetState::InitOffsets (for other cases) nsTableFrame::IntrinsicWidthOffsets (in this case).

Are you testing with different borders on the two sides?

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #9)
> Are you testing with different borders on the two sides?

More specifically, with an odd pixel border on the left and no border on the right, and then vice versa.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Maybe the problem is that nsCSSOffsetState::InitOffsets should be calling GetIncludedOuterBCBorder instead of GetExcludedOuterBCBorder?

Comment 12

[Mats Palmgren (inactive)]

Attachment: Testcase #3a (Quirks mode)

Comment 13

[Mats Palmgren (inactive)]

Attachment: Testcase #3b (Standards mode)

Comment 14

[Mats Palmgren (inactive)]

Attachment: Testcase #4a (Quirks mode)

Comment 15

[Mats Palmgren (inactive)]

Attachment: Testcase #4b (Standards mode)

Comment 16

[Mats Palmgren (inactive)]

Attachment: Testcase #5

Comment 17

[Mats Palmgren (inactive)]

Attachment: Patch rev. 3

(In reply to comment #11)
> Maybe the problem is that nsCSSOffsetState::InitOffsets should be calling
> GetIncludedOuterBCBorder instead of GetExcludedOuterBCBorder?

Agree.

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 250592 [details] [diff] [review]
Patch rev. 3

r+sr=dbaron

Comment 19

[Mats Palmgren (inactive)]

Checked in to trunk at 2007-01-05 07:38 PST

-> FIXED