Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove nsIDOMEventReceiver

RESOLVED FIXED

Status

()

Core
DOM: Events
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

11 years ago
After bug 363067, nsIDOMEventReceiver could be merged to nsPIDOMEventTarget.
(Assignee)

Comment 1

11 years ago
Actually, nsIDOMEventReceiver can be just removed and use nsIEventListenerManager when really needed.
(Assignee)

Comment 2

11 years ago
WIP patch containing also bug 363067 is here http://www.cs.helsinki.fi/u/pettay/moztests/events/remove_nsidomeventreceiver.diff
(Assignee)

Comment 3

11 years ago
http://www.cs.helsinki.fi/u/pettay/moztests/events/remove_nsidomeventreceiver.diff
should remove now all uses of nsIDOMEventReceiver.
And it even compiles (ff, tb, sm) :)

Waiting for bug 363067.
(Assignee)

Updated

10 years ago
Depends on: 378102
(Assignee)

Comment 4

10 years ago
Created attachment 262273 [details] [diff] [review]
v1
(Assignee)

Updated

10 years ago
Attachment #262273 - Attachment is patch: true
Attachment #262273 - Attachment mime type: text/x-patch → text/plain
(Assignee)

Updated

10 years ago
Attachment #262273 - Flags: review?(jst)
Comment on attachment 262273 [details] [diff] [review]
v1

- In content/xbl/public/nsIXBLService.h:

-  NS_IMETHOD AttachGlobalKeyHandler(nsIDOMEventReceiver* aElement)=0;
+  NS_IMETHOD AttachGlobalKeyHandler(nsPIDOMEventTarget* aTarget)=0;

Since you're changing this "interface", you should bump the IID here (even if it's not in IDL). Same for nsPIDOMEventTarget.

- In embedding/browser/gtk/src/EmbedPrivate.h:

   EmbedContentListener          *mContentListener;
   nsCOMPtr<nsISupports>          mContentListenerGuard;
   EmbedEventListener            *mEventListener;
   nsCOMPtr<nsISupports>          mEventListenerGuard;
 
   nsCOMPtr<nsIWebNavigation>     mNavigation;
   nsCOMPtr<nsISHistory>          mSessionHistory;
 
-  // our event receiver
-  nsCOMPtr<nsIDOMEventReceiver>  mEventReceiver;
+  nsCOMPtr<nsPIDOMEventTarget>  mEventTarget;

Add a space to make member names line up again.

r+sr=jst with that.
Attachment #262273 - Flags: superreview+
Attachment #262273 - Flags: review?(jst)
Attachment #262273 - Flags: review+
(Assignee)

Comment 6

10 years ago
I'll check this in during next weekend, when there aren't too many
other check-ins.
(Assignee)

Comment 7

10 years ago
bah, I just checked this in. Hoping not to see to much red in tboxes.
(Assignee)

Comment 8

10 years ago
backed out. some chrome and mochitests failed and couldn't immediately see where to problem is.
(Assignee)

Comment 9

10 years ago
Created attachment 264731 [details] [diff] [review]
checked in
Attachment #262273 - Attachment is obsolete: true
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

10 years ago
nsIDOMEventTarget occurs still few times in the tree, for example in
some comments. I'll post a small patch to remove those.
(Assignee)

Comment 11

10 years ago
Created attachment 264801 [details] [diff] [review]
leftovers

Things which aren't usually (or ever) compiled.
The strange looking part is nsWindowRoot, but those macros don't
actually use the second parameter currently.
Attachment #264801 - Flags: superreview?(jst)
Attachment #264801 - Flags: review?(jst)
Comment on attachment 264801 [details] [diff] [review]
leftovers

r+sr=jst
Attachment #264801 - Flags: superreview?(jst)
Attachment #264801 - Flags: superreview+
Attachment #264801 - Flags: review?(jst)
Attachment #264801 - Flags: review+

Updated

10 years ago
Depends on: 380716
(Assignee)

Updated

10 years ago
No longer depends on: 380716
Depends on: 408238
You need to log in before you can comment on or make changes to this bug.