363125 - location bar stretched vertically

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[philippe (part-time)]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20061207 Minefield/3.0a1 ID:2006120713

the location and the icons in it are stretched vertically.

Comment 1

[philippe (part-time)]

Attachment: screenshot

Comment 2

[philippe (part-time)]

regressed between 2006120616 (works) and 2006120706 (fails)

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20061206 Minefield/3.0a1 ID:2006120616 [cairo]
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20061207 Minefield/3.0a1 ID:2006120706 [cairo]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-12-06+16%3A00%3A00&maxdate=2006-12-07+07%3A00%3A00&cvsroot=%2Fcvsroot

bug 354644 ?

Comment 3

[Phil Ringnalda (:philor)]

> bug 354644 ?

Nope, bug 359056, confirmed by local backout, though I was already suspicious since that breakage looks a whole lot like a whole stack with every bit of it thinking it needs the dropmarker image.

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> > bug 354644 ?
> Nope, bug 359056

So it seems you mixed that up when changing the blocks field.

Comment 5

[Asaf Romano (gone)]

Attachment: patch

Comment 6

[Robert Sayre]

*** Bug 363174 has been marked as a duplicate of this bug. ***

Comment 7

[Shawn Smith]

Better, but the background color of the address box is now grey?  I suspect it should be white.  Also, the go button does not align correctly with the address box like firefox 2.0 builds do.  Suspect another fix was missed somewhere.

Comment 8

[Asaf Romano (gone)]

The grey-thing is a regression from enabling cairo-cocoa, "dunno" on the go button alignment.

Comment 9

[Shawn Wilsher :sdwilsh]

(In reply to comment #7)
> Better, but the background color of the address box is now grey?  I suspect it
> should be white.  Also, the go button does not align correctly with the address
> box like firefox 2.0 builds do.  Suspect another fix was missed somewhere.

Go button is a bit smaller height wise compared to the url bar.  Both of those should be filed as separate bugs if they haven't been filed already.

Comment 10

[Phil Ringnalda (:philor)]

bug 361922, though I suspect it will be fixed as bug 362428, and bug 360211