363402 - [reflow branch] Layout issue at wikipedia

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P1)

Description

[Biju]

I dont know whether this is a bug 
go to 
http://en.wikipedia.org/wiki/South_Asian_Association_for_Regional_Cooperation
see the Info box on right top
"South Asian Association of Regional Cooperation" is not broken into two lines.

please feel free to change heading.

Comment 1

[Biju]

Attachment: Firefox.png

Comment 2

[Biju]

Attachment: IE.png

Comment 3

[Biju]

Attachment: SAARC.htm

Comment 4

[Ria Klaassen (not reading all bugmail)]

Regression between 1.9a1_2006120714 and 1.9a1_2006120722 which points to Bug 300030.

Comment 5

[Biju]

(In reply to comment #4)
> Regression between 1.9a1_2006120714 and 1.9a1_2006120722 
> which points to Bug 300030.
so CCing  David Baron 

Comment 6

[Mats Palmgren (inactive)]

Attachment: Somewhat reduced testcase

Comment 7

[Mats Palmgren (inactive)]

I think this is the same issue as bug 363248. The table caption is too wide.

Comment 8

[Sandro Steger]

The same problem occures on the German wikipedia article "Eibe" (engl. "Taxus").
Here the link: http://de.wikipedia.org/wiki/Eiben

I was able to reproduce the error on the following platforms:
Windows 2000 SP 4 - Firefox 1.5
Windows 2000 SP 4 - Firefox 2.0.0.4
Windows XP SP 2 - Firefox 2.0.0.4
Fedora Core 3 - Firefox 1.5

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Sandro, this bug is for a regression from known check-in exclusive to the Gecko 1.9 trunk (i.e. the core of what will be Firefox 3.0). Please file a new bug if you're having problems with Firefox 1.5/2.0 as it's most likely unrelated to this bug.

Comment 10

[Sandro Steger]

Oh, I'm deeply sorry , I posted it on the wrong bugreport O.o Please ignore my last comment.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Not completely fixed by bug 363248, though.  The intrinsic width of the thing with the table and caption in it is still too wide, it seems.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And it's still a problem in my testcases (attachment 305673 [details] and attachment 305674 [details]) that I used there -- I just didn't notice it.  In particular, under "floating table", for the "top" and "bottom" caption-side cases, see the cases with "caption with a decent sized pref width".

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

We need to do this computation because of bug 349457, essentially due to the weirdness of being a block that's not the containing block for its children's percentage widths.

But what we do really does need to match nsTableOuterFrame::Reflow; this makes it do so.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 306158 [details] [diff] [review]
patch

This was supposed to be fixed by the changes I landed yesterday, but I missed this bit.

I'd be ok with landing this after the final beta, but I'd prefer to have it in.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306158 [details] [diff] [review]
patch

a1.9b4=beltzner

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk 2008-02-28 09:55 -0800.

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Fixed?