EmbedPrivate::ScrollToSelectedNode doesn't initialize rv if !aDOMNode

RESOLVED FIXED

Status

--
trivial
RESOLVED FIXED
12 years ago
7 years ago

People

(Reporter: timeless, Assigned: sciguyryan)

Tracking

Trunk
x86
SunOS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

12 years ago
Anyway, I'm using an auditing app that I expect never to use again, so I'm making a couple of notes.
(Assignee)

Comment 1

12 years ago
Created attachment 248271 [details] [diff] [review]
Patch v1

Patch v1

* Simply initialize rv too NS_ERROR_FAILURE. If !aDOMNode then there is no chance of success. Not sure how much of an effect this is going to have as the only use of this method checks the aDOMNode parameter before passing it.
Assignee: nobody → sciguyryan+bugzilla
Status: NEW → ASSIGNED
Attachment #248271 - Flags: review?(timeless)
(Reporter)

Updated

12 years ago
Attachment #248271 - Flags: review?(timeless) → review+
(Assignee)

Comment 2

12 years ago
Checked in my timeless, marking as RESOLVED FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

12 years ago
Comment on attachment 248271 [details] [diff] [review]
Patch v1

mozilla/embedding/browser/gtk/src/EmbedPrivate.cpp 	1.74
Attachment #248271 - Attachment is obsolete: true
QA Contact: xre.startup → gtk-widget
Component: Embedding: GTK Widget → Embedding: GTK Widget
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.