Closed
Bug 363446
Opened 18 years ago
Closed 18 years ago
EmbedPrivate::ScrollToSelectedNode doesn't initialize rv if !aDOMNode
Categories
(Core Graveyard :: Embedding: GTK Widget, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: sciguyryan)
References
Details
Attachments
(1 obsolete file)
Anyway, I'm using an auditing app that I expect never to use again, so I'm making a couple of notes.
|
Assignee | |
Comment 1•18 years ago
|
||
Patch v1
* Simply initialize rv too NS_ERROR_FAILURE. If !aDOMNode then there is no chance of success. Not sure how much of an effect this is going to have as the only use of this method checks the aDOMNode parameter before passing it.
Assignee: nobody → sciguyryan+bugzilla
Status: NEW → ASSIGNED
Attachment #248271 -
Flags: review?(timeless)
Attachment #248271 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Checked in my timeless, marking as RESOLVED FIXED.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment on attachment 248271 [details] [diff] [review]
Patch v1
mozilla/embedding/browser/gtk/src/EmbedPrivate.cpp 1.74
Attachment #248271 -
Attachment is obsolete: true
|
||
Updated•17 years ago
|
QA Contact: xre.startup → gtk-widget
|
||
Updated•13 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•