Use file proxy in window titlebar when viewing local files (cmd-click to show path)

RESOLVED WONTFIX

Status

Camino Graveyard
OS Integration
RESOLVED WONTFIX
12 years ago
12 years ago

People

(Reporter: froodian (Ian Leue), Assigned: froodian (Ian Leue))

Tracking

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

12 years ago
This is like bug 175470, but for files (cmd-click in titlebar should display file path, dragging titlebar icon should work as proxy).  While bug 175470 is slightly controversial, we should absolutely do this for files for consistency with the rest of of the OS.  I could have sworn this was filed, but I couldn't find it...
(Assignee)

Comment 1

12 years ago
Created attachment 248435 [details] [diff] [review]
Patch
Attachment #248435 - Flags: review?(mozilla)
(Assignee)

Comment 2

12 years ago
Created attachment 248437 [details] [diff] [review]
Patch

Per IRC, doing a variable name change and commenting to make it clear why we're setting the path to @"" in the nil case.
Attachment #248435 - Attachment is obsolete: true
Attachment #248437 - Flags: review?(mozilla)
Attachment #248435 - Flags: review?(mozilla)

Comment 3

12 years ago
Comment on attachment 248437 [details] [diff] [review]
Patch

codewise r=me
Attachment #248437 - Flags: review?(mozilla) → review+
(Assignee)

Updated

12 years ago
Attachment #248437 - Flags: superreview?(stuart.morgan)
(Assignee)

Comment 4

12 years ago
Comment on attachment 248437 [details] [diff] [review]
Patch

This is all fine and well for when we just load a new page, but it won't persist across tab changes.
Attachment #248437 - Flags: superreview?(stuart.morgan) → review-
(Assignee)

Comment 5

12 years ago
Created attachment 248444 [details] [diff] [review]
Patch

Now with 70% less wrongness.
Attachment #248437 - Attachment is obsolete: true
Attachment #248444 - Flags: review?(mozilla)
(In reply to comment #0)
> I could have sworn this was filed, but I couldn't find it...
 
Maybe you were thinking of the related bug 346228?
(Assignee)

Comment 7

12 years ago
Created attachment 248451 [details] [diff] [review]
Patch

Per IRC, no point in keeping anything we don't really need in memory.  Instead, this just grabs the URL and calculates the path from it each time we change the window title.  It also changes the paradigm slightly (by giving |updateWindowTitle| no arguments) so that updateWindowTitle can pull all of its information, rather than being given the title and pulling the path...

Which has the added bonus of making bug 309874 easy to fix.  This always truncates the title to 80 chars if on 10.3 or previous, and lets the OS truncate the title gracefully if we're on 10.4 or higher.
Attachment #248444 - Attachment is obsolete: true
Attachment #248451 - Flags: review?(mozilla)
Attachment #248444 - Flags: review?(mozilla)
(Assignee)

Updated

12 years ago
Blocks: 309874

Comment 8

12 years ago
Comment on attachment 248451 [details] [diff] [review]
Patch

codewise r=me; I think I like this one.
Attachment #248451 - Flags: review?(mozilla) → review+
(Assignee)

Updated

12 years ago
Attachment #248451 - Flags: superreview?(stuart.morgan)
(Assignee)

Updated

12 years ago
No longer blocks: 309874

Comment 9

12 years ago
Comment on attachment 248451 [details] [diff] [review]
Patch

We need to discuss whether we want this before it's sr'd. It creates a significant inconsistency between the appearance and behavior of the title bar for local files vs. web pages. Right now we always have a favicon in the tabs, and it does a reasonable thing for whatever it represents. Having a favicon in the title bar only sometimes doesn't really seem like a good idea to me, since it's not the way we do things anywhere else. I think we need to do the same thing here in all cases.

There's also the question of how many places we want the favicon showing up. Having it in the URL bar then again right above it in the title bar seems a bit weird.
Attachment #248451 - Flags: superreview?(stuart.morgan)
My 2¢ wrt this is that internal consistency here is more important than acting 100% like a document-based Cocoa app.  So I'm happy to forgo the icon in the titlebar, but I think we should keep the menu since we do plan (last I checked) to add that for sites as well.
(Assignee)

Comment 11

12 years ago
WONTFIX in favor of bug 364198.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.