[Mac a11y] Make accessibles that don't have an action expose the parent's actions

RESOLVED INCOMPLETE

Status

()

--
enhancement
RESOLVED INCOMPLETE
12 years ago
2 years ago

People

(Reporter: hwaara, Assigned: hwaara)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [auto-closed:inactivity])

Attachments

(1 attachment)

Fix
1.09 KB, patch
surkov
: review+
ginnchen+exoracle
: review-
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
For accessibles with no action, they might as well inherit the parent's actions so *something* is possible to do while that object has focus.

For example, if the hierarchy looks like this:

<lots of parents>
 <AXLink>
  <AXImage>

An image by itself has no actions, but the link has the click action, so the image should be clickable.

This seems to be what also Safari does.
(Assignee)

Comment 1

12 years ago
Created attachment 248661 [details] [diff] [review]
Fix
Attachment #248661 - Flags: review?(surkov.alexander)
Comment on attachment 248661 [details] [diff] [review]
Fix

Looks ok. But please get additional review from aaronlev or somebody else who will capable to confirm how much this is accessible :) I just didn't see in accessibility code something similar.
Attachment #248661 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

12 years ago
Comment on attachment 248661 [details] [diff] [review]
Fix

Ginn, this fix is so that children (that have no actions) will inherit the action of their parent.

For example, an image by itself has no action. But let's say a link does.

If the hierarchy looks like this:

AXLink
  AXImage

Then the image will get that action too (so you can execute it, when the image has focus).
Attachment #248661 - Flags: review?(ginn.chen)
(Assignee)

Comment 4

12 years ago
Actually, now that I mention it, AXLinks don't have the click action. I should probably fix that. :)  Filed bug 363927

Comment 5

12 years ago
I'm not sure about this approach.
I think it's not the same way we did in XP code.

Aaron, what do you think? 

Comment 6

12 years ago
Comment on attachment 248661 [details] [diff] [review]
Fix

Håkan, I don't think it works.

I got action AXRaise for everything for everything in the web page.
Because it tries to get its parent, parent's parent, ..., till AXWindow.

For Safari, the action I got is like this,
AXWindow --- AXRaise
  AXGroup --- no action
     AXScrollArea -- no action
       AXWebArea -- no action
          AXLink -- AXPress
Attachment #248661 - Flags: review?(ginn.chen) → review-
AUTO-CLOSED. This bug untouched for over 2000 days. Please reopen if you can confirm the bug and help it progress.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
Whiteboard: [auto-closed:inactivity]
You need to log in before you can comment on or make changes to this bug.