363853 - Crash saving page as PDF [@ gfxQuartzPDFSurface::~gfxQuartzPDFSurface]

Status: VERIFIED INVALID

(Core :: Graphics, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Current trunk build

STEPS TO REPRODUCE:

1)  Install OSX
2)  Install a trunk Firefox build
3)  Start Firefox
4)  Wait for start page to load
5)  Hit Command-P.
6)  Click the "PDF v" dropdown at the bottom left of the dialog and select "Save
    as PDF".
7)  Enter a filename ("test.pdf" is good)
8)  Click "Save"

EXPECTED RESULTS:  Not crash

ACTUAL RESULTS:  Crash in gfxQuartzPDFSurface::~gfxQuartzPDFSurface.

ADDITIONAL INFORMATION:

The dialog after step 5 has "No printer selected" in the printer dropdown.  We crash at 

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_PROTECTION_FAILURE at address: 0x00000010
0x0059e420 in gfxQuartzPDFSurface::~gfxQuartzPDFSurface (this=0x3770ec70) at ../../../../mozilla/gfx/thebes/src/gfxQuartzPDFSurface.cpp:119
119         cupsPrintFile(defaultDest->name, mFilename, "Mozilla Print Job", defaultDest->num_options, defaultDest->options);
(gdb) p defaultDest
$1 = ($_ *) 0x0

I don't see why I should need to select/create/whatever a printer to print to file, and with non-cairo builds I totally don't have to.  Since there's no printer attached to this computer and probably never will be, I feel that we should allow saving to file with the "No printer selected" setting.  But we _definitely_ shouldn't be crashing.

In any case, this is pretty much a blocker for me using trunk builds for daily browsing, since I need to be able to print receipts and such to file.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

we no longer use this code

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yep.  No  more crash.