Closed Bug 363917 Opened 18 years ago Closed 18 years ago

js_GC fails to clear cx->lastInternalResult root

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: brendan, Assigned: brendan)

Details

(Keywords: fixed1.8.0.10, fixed1.8.1.2)

Attachments

(1 file)

We never added that clearing step to js_ForceGC, which moved into js_GC in the patch for bug 341821. D'oh! Patch next.

/be
cx->lastInternalResult debuted in the patch for bug 313952.

/be
Status: NEW → ASSIGNED
Priority: -- → P1
Attached patch fixSplinter Review
Attachment #248719 - Flags: review?(igor.bukanov)
Attachment #248719 - Flags: review?(igor.bukanov) → review+
Fixed on trunk:

Checking in jsgc.c;
/cvsroot/mozilla/js/src/jsgc.c,v  <--  jsgc.c
new revision: 3.192; previous revision: 3.191
done

/be
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.2?
Flags: blocking1.8.0.10?
Resolution: --- → FIXED
Comment on attachment 248719 [details] [diff] [review]
fix

Fixes bloat bugs.

/be
Attachment #248719 - Flags: approval1.8.1.2?
Attachment #248719 - Flags: approval1.8.0.10?
Flags: in-testsuite-
Flags: blocking1.8.1.2?
Flags: blocking1.8.1.2+
Flags: blocking1.8.0.10?
Flags: blocking1.8.0.10+
Comment on attachment 248719 [details] [diff] [review]
fix

approved for 1.8/1.8.0 branches, a=dveditz for drivers
Attachment #248719 - Flags: approval1.8.1.2?
Attachment #248719 - Flags: approval1.8.1.2+
Attachment #248719 - Flags: approval1.8.0.10?
Attachment #248719 - Flags: approval1.8.0.10+
new revision: 3.104.2.30; previous revision: 3.104.2.29
new revision: 3.104.2.3.2.16; previous revision: 3.104.2.3.2.15

/be
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: