js_GC fails to clear cx->lastInternalResult root

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
JavaScript Engine
P1
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: brendan, Assigned: brendan)

Tracking

({fixed1.8.0.10, fixed1.8.1.2})

Trunk
mozilla1.9alpha1
fixed1.8.0.10, fixed1.8.1.2
Points:
---
Bug Flags:
blocking1.8.1.2 +
wanted1.8.1.x +
blocking1.8.0.10 +
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
We never added that clearing step to js_ForceGC, which moved into js_GC in the patch for bug 341821. D'oh! Patch next.

/be
(Assignee)

Comment 1

11 years ago
cx->lastInternalResult debuted in the patch for bug 313952.

/be
Status: NEW → ASSIGNED
Priority: -- → P1
(Assignee)

Comment 2

11 years ago
Created attachment 248719 [details] [diff] [review]
fix
Attachment #248719 - Flags: review?(igor.bukanov)

Updated

11 years ago
Attachment #248719 - Flags: review?(igor.bukanov) → review+
(Assignee)

Comment 3

11 years ago
Fixed on trunk:

Checking in jsgc.c;
/cvsroot/mozilla/js/src/jsgc.c,v  <--  jsgc.c
new revision: 3.192; previous revision: 3.191
done

/be
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.2?
Flags: blocking1.8.0.10?
Resolution: --- → FIXED
(Assignee)

Comment 4

11 years ago
Comment on attachment 248719 [details] [diff] [review]
fix

Fixes bloat bugs.

/be
Attachment #248719 - Flags: approval1.8.1.2?
Attachment #248719 - Flags: approval1.8.0.10?

Updated

11 years ago
Flags: in-testsuite-
Flags: blocking1.8.1.2?
Flags: blocking1.8.1.2+
Flags: blocking1.8.0.10?
Flags: blocking1.8.0.10+
Comment on attachment 248719 [details] [diff] [review]
fix

approved for 1.8/1.8.0 branches, a=dveditz for drivers
Attachment #248719 - Flags: approval1.8.1.2?
Attachment #248719 - Flags: approval1.8.1.2+
Attachment #248719 - Flags: approval1.8.0.10?
Attachment #248719 - Flags: approval1.8.0.10+
(Assignee)

Comment 6

11 years ago
new revision: 3.104.2.30; previous revision: 3.104.2.29
new revision: 3.104.2.3.2.16; previous revision: 3.104.2.3.2.15

/be
Keywords: fixed1.8.0.10, fixed1.8.1.2
You need to log in before you can comment on or make changes to this bug.