363917 - js_GC fails to clear cx->lastInternalResult root

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Brendan Eich [:brendan]]

We never added that clearing step to js_ForceGC, which moved into js_GC in the patch for bug 341821. D'oh! Patch next.

/be

Comment 1

[Brendan Eich [:brendan]]

cx->lastInternalResult debuted in the patch for bug 313952.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Comment 3

[Brendan Eich [:brendan]]

Fixed on trunk:

Checking in jsgc.c;
/cvsroot/mozilla/js/src/jsgc.c,v  <--  jsgc.c
new revision: 3.192; previous revision: 3.191
done

/be

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 248719 [details] [diff] [review]
fix

Fixes bloat bugs.

/be

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 248719 [details] [diff] [review]
fix

approved for 1.8/1.8.0 branches, a=dveditz for drivers

Comment 6

[Brendan Eich [:brendan]]

new revision: 3.104.2.30; previous revision: 3.104.2.29
new revision: 3.104.2.3.2.16; previous revision: 3.104.2.3.2.15

/be