IIS5 gives 405 error on login from homepage (index.cgi not explicitly specified)

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
User Interface
--
minor
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Michael Kincaid, Assigned: Michael Kincaid)

Tracking

2.22.1
Bugzilla 3.0
x86
Windows XP
Bug Flags:
approval +
approval3.0 +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: 2.22.1

IIS5 does not accept POST (or for that matter any verb but GET or HEAD) without an explicit filename, because it isn't smart enough to figure out that a POST to
http://my.server.name/ should use the same handler as a POST to
http://my.server.name/index.cgi. Instead it returns a 405 error. MS says they've fixed it in IIS6:
http://support.microsoft.com/kb/216493

Reproducible: Always

Steps to Reproduce:
1. Running Bugzilla on IIS5/Win32, go to Bugzilla home page when not logged in
2. Attempt to log in on the home page.
Actual Results:  
IIS returns 405 error. User is not logged in. Login from other pages is possible.

Expected Results:  
Logged in home page would appear.

I've attached a patch to login-small.default.tmpl to work around this problem by always supplying index.cgi as the current path where not otherwise specified.
(Assignee)

Comment 1

11 years ago
Created attachment 248787 [details] [diff] [review]
Patch to login-small.html.tmpl to explicity supply index.cgi as part of the POST url
(Assignee)

Updated

11 years ago
Version: unspecified → 2.22.1

Comment 2

10 years ago
*** This bug has been confirmed by popular vote. ***
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

10 years ago
I can confirm that this bug is still a problem in Bugzilla 3.0rc1 on IIS 5.1 and that Michael Kincaid's fix still works in Bugzilla 3.0rc1 
(Assignee)

Comment 4

10 years ago
Created attachment 265166 [details] [diff] [review]
Patch to login.html.tmpl to explicitly supply index.cgi as part of the POST url

This also affects the "Log in" link from the homepage, which uses login.html.tmpl rather than login-small.html.tmpl, so I've attached a patch for login.html.tmpl as well.
(Assignee)

Updated

10 years ago
Version: 2.22.1 → 3.0

Comment 5

10 years ago
Wow, that's SO STUPID (of IIS5). Like, that's terminally dumb.

I don't really want to put this fix into the main Bugzilla itself, but we can certainly have it here for people who need it. I just don't like using index.cgi manually when we don't have to.
Version: 3.0 → 2.22.1

Comment 6

10 years ago
Weird. Using Apache, the filename on my installation (both 3.0 and 3.1) is http://.../bugzilla/index.cgi, not http://.../bugzilla/ alone. Why isn't CGI returning the 'index.cgi' part when used with IIS5? IMO, it shouldn't be related to your web server.
the cgi only knows what it can see in %ENV, which is set up by the web server.

Comment 8

10 years ago
Being that this only specifies index.cgi to be the target if the target is undefined, IMHO it should go in.
Assignee: ui → michael

Comment 9

10 years ago
(In reply to comment #8)
> Being that this only specifies index.cgi to be the target if the target is
> undefined, IMHO it should go in.

Yeah, this probably doesn't hurt.
(Assignee)

Updated

10 years ago
Flags: approval?

Comment 10

10 years ago
Before requesting approval, you need your patch to be reviewed. Set the review flag to '?' first and wait for a reviewer to grant review.
Flags: approval?
(Assignee)

Updated

10 years ago
Attachment #248787 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #265166 - Flags: review?
Comment on attachment 248787 [details] [diff] [review]
Patch to login-small.html.tmpl to explicity supply index.cgi as part of the POST url

duplicate attachment
Attachment #248787 - Attachment is obsolete: true
Attachment #248787 - Flags: review?
Comment on attachment 248787 [details] [diff] [review]
Patch to login-small.html.tmpl to explicity supply index.cgi as part of the POST url

er, nevermind that, this is the same patch to two different templates :)  oops.  Was going to grant review anyway, this is pretty obvious.
Attachment #248787 - Attachment is obsolete: false
Attachment #248787 - Flags: review+
Attachment #265166 - Flags: review? → review+
Flags: approval?
Created attachment 265531 [details] [diff] [review]
combined patch (same as above two)

This is the same as the above patches, with the windows formatting changed to unix and using unified diff format to make it easy to apply.

Applies cleanly on both branches.
Attachment #248787 - Attachment is obsolete: true
Attachment #265166 - Attachment is obsolete: true
Attachment #265531 - Flags: review+
Flags: approval? → approval+
Target Milestone: --- → Bugzilla 3.0
Trunk:

Checking in template/en/default/account/auth/login-small.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v  <--  login-small.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/account/auth/login.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl,v  <--  login.html.tmpl
new revision: 1.19; previous revision: 1.18
done

3.0 branch:

Checking in template/en/default/account/auth/login-small.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v  <--  login-small.html.tmpl
new revision: 1.8.2.1; previous revision: 1.8
done
Checking in template/en/default/account/auth/login.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl,v  <--  login.html.tmpl
new revision: 1.18.2.1; previous revision: 1.18
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Flags: approval3.0+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.