364088 - A couple of fixes to the Stage automation step

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[J. Paul Reed [:preed]]

Ran into a couple of problems while using the automation's Stage step; I'll post the patch I made to get it working here.

Comment 1

[J. Paul Reed [:preed]]

Attachment: Minor Stage step changes

This changes:

-- use strict; for some reason, it's either off or not propagating; I didn't bother delving into why, but turning it on caught some errors that I fixed.

-- find() needs a function ref, not a function; I actually changed it to be an anonymous ref, so I could use $this, which TrimCallback() expects to exist.

-- Move the getgrnam() for the product down to where it's used, since it's only used in one branch of the if, and that call can be expensive for every directory entry encountered (very expensive if NIS is used...)

-- ja.xpi was not removed for mac (which is ja-JP-mac.xpi)

-- the ja-JP-mac.xpi regex for win32 and linux weren't quite right, since name includes the entire path.

-- there was a comment referencing deletion of zip files, but no code to do it

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 248879 [details] [diff] [review]
Minor Stage step changes

Good stuff, odd about use strict, I assumed since it's used in the main app that it'd propagate. 

Maybe it needs to be in Bootstrap/Step.pm, which all of the Step/*.pm are subclasses of?

In any event, feel free to land this in CVS.

Comment 3

[J. Paul Reed [:preed]]

Landed this today.