364167 - no space in Attachments on this Bug:263

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[timeless]

tip:
Attachments on this Bug:263 

bmo:
Attachments on this Bug: #246180

I don't care about the # or not. the lack of space in the token "Bug:263" bothers me.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Make it look exactly like bmo does.

Comment 2

[Frédéric Buclin]

Comment on attachment 248941 [details] [diff] [review]
patch - v1

>-      [% a %]
>+      #[% a %]

Those # are ugly. We removed them, so please do not bring them back. That's not the topic of this bug anyway.

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v2

Ok, just add a space.

Comment 4

[Frédéric Buclin]

Comment on attachment 248998 [details] [diff] [review]
patch - v2

>   Attachments on this [% terms.Bug %]:
>+
>   [% FOREACH a = attachments %]
>     [% IF a == attachment.id %]
>       [% a %]

Adding an empty line is an ugly way to fix it. Anyway, this patch doesn't work if the attachment you are viewing is not the first one for this bug. You have to write [%+ a %] here instead of [% a %] alone.

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v3

Ooo, I didn't know about [%+. Cool, thanks! :)

Comment 6

[Reed Loden [:reed]]

Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.39; previous revision: 1.38
done