no space in Attachments on this Bug:263

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Attachments & Requests
--
trivial
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: timeless, Assigned: reed)

Tracking

({regression, ue})

2.23.3
Bugzilla 3.0
regression, ue
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

11 years ago
tip:
Attachments on this Bug:263 

bmo:
Attachments on this Bug: #246180

I don't care about the # or not. the lack of space in the token "Bug:263" bothers me.
(Assignee)

Comment 1

11 years ago
Created attachment 248941 [details] [diff] [review]
patch - v1

Make it look exactly like bmo does.
Assignee: attach-and-request → reed
Status: NEW → ASSIGNED
Attachment #248941 - Flags: review?(bugzilla-mozilla)

Comment 2

11 years ago
Comment on attachment 248941 [details] [diff] [review]
patch - v1

>-      [% a %]
>+      #[% a %]

Those # are ugly. We removed them, so please do not bring them back. That's not the topic of this bug anyway.
Attachment #248941 - Flags: review?(bugzilla-mozilla) → review-
(Assignee)

Comment 3

11 years ago
Created attachment 248998 [details] [diff] [review]
patch - v2

Ok, just add a space.
Attachment #248941 - Attachment is obsolete: true
Attachment #248998 - Flags: review?(bugzilla-mozilla)

Comment 4

11 years ago
Comment on attachment 248998 [details] [diff] [review]
patch - v2

>   Attachments on this [% terms.Bug %]:
>+
>   [% FOREACH a = attachments %]
>     [% IF a == attachment.id %]
>       [% a %]

Adding an empty line is an ugly way to fix it. Anyway, this patch doesn't work if the attachment you are viewing is not the first one for this bug. You have to write [%+ a %] here instead of [% a %] alone.
Attachment #248998 - Flags: review?(bugzilla-mozilla) → review-

Updated

11 years ago
Severity: normal → trivial
OS: Mac OS X 10.3 → All
Hardware: Macintosh → All
Target Milestone: --- → Bugzilla 3.0
(Assignee)

Comment 5

11 years ago
Created attachment 249000 [details] [diff] [review]
patch - v3

Ooo, I didn't know about [%+. Cool, thanks! :)
Attachment #248998 - Attachment is obsolete: true
Attachment #249000 - Flags: review?(LpSolit)

Updated

11 years ago
Attachment #249000 - Flags: review?(LpSolit) → review+

Updated

11 years ago
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 6

11 years ago
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.39; previous revision: 1.38
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.