364172 - Wording on showdependencytree.cgi is bad when there are no dependencies

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P5)

Description

[timeless]

[ Show Resolved ] Max Depth:   [  1  ] [  <  ] _____ [  >  ] [  Unlimited  ]                                               
                                                                                                                              
  0 Open bugs that bug 20 depends on                                                                                          
                                                                                                                              
   None                                     

In fact. The whole phrasing is indeed quite awkward.

Comment 1

[Max Kanat-Alexander]

This has got to be the mother of all trivial bugs. :-)

Comment 2

[timeless]

*** Bug 364517 has been marked as a duplicate of this bug. ***

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v1

Change wording to be much nicer, fix spelling error, and correct validation issue.

Comment 4

[Olav Vitters]

Comment on attachment 249610 [details] [diff] [review]
patch - v1

>Index: template/en/default/bug/dependency-tree.html.tmpl

>     [% END %]
>+    [% IF ids.size > 0 %]

Nit: Make that [% IF ids.size %]

>+        [% IF hide_resolved %]
>+            open [% (ids.size == 1) ? terms.bug : terms.bugs %]:
>+        [% ELSE %]
>+            [%+ (ids.size == 1) ? terms.bug : terms.bugs %]:
>+        [%- END %] 

More complicated that it has to be. Just do a:
[% IF hide_resolved %]open[% END %]
[%+ (ids.size == 1) ? terms.bug : terms.bugs %]:

(fix the [%- [%+ etc as appropriate).

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v2

Correct nit and cleaned-up logic.

Comment 6

[Olav Vitters]

Comment on attachment 249704 [details] [diff] [review]
patch - v2

>Index: template/en/default/bug/dependency-tree.html.tmpl

>     [% END %]
>+    [% IF ids.size > 0 %]

Nit is still there. Can be fixed on checkin (doesn't have to be.. noticed other parts of the file use the same form).

Comment 7

[Reed Loden [:reed]]

Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v  <--  dependency-tree.html.tmpl
new revision: 1.25; previous revision: 1.24
done