Closed Bug 364223 Opened 18 years ago Closed 12 years ago

PAC threadsafety problem: nsStandardURL not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: timeless, Unassigned)

References

()

Details

(Keywords: assertion, testcase)

bug 111384 comment 42 of course mentions this....

ntdll!DbgBreakPoint
xpcom_core!Break(char * aMsg = 0x04d0fa28 "###!!! ASSERTION: nsStandardURL not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file c:/home/soref/mozilla.org/mozilla/netwerk/base/src/nsStandardURL.cpp, line 929")+0x145 [c:\home\mozilla.org\mozilla\xpcom\base\nsdebugimpl.cpp @ 472]
xpcom_core!NS_DebugBreak_P(unsigned int aSeverity = 1, char * aStr = 0x01a69580 "nsStandardURL not thread-safe", char * aExpr = 0x01a65658 "_mOwningThread.GetThread() == PR_GetCurrentThread()", char * aFile = 0x01a694d0 "c:/home/soref/mozilla.org/mozilla/netwerk/base/src/nsStandardURL.cpp", int aLine = 929)+0x1c2 [c:\home\mozilla.org\mozilla\xpcom\base\nsdebugimpl.cpp @ 352]
necko!nsStandardURL::Release(void)+0x54 [c:\home\mozilla.org\mozilla\netwerk\base\src\nsstandardurl.cpp @ 929]
necko!nsCOMPtr<nsIURI>::~nsCOMPtr<nsIURI>(void)+0x1f [c:\home\mozilla.org\mozilla\dbg-firefox-i686-pc-mingw32\dist\include\xpcom\nscomptr.h @ 583]
necko!PendingPACQuery::Release(void)+0x57 [c:\home\mozilla.org\mozilla\netwerk\base\src\nspacman.cpp @ 102]
xpcom_core!nsCOMPtr_base::~nsCOMPtr_base(void)+0x1e [c:\home\mozilla.org\mozilla\dbg-firefox-i686-pc-mingw32\xpcom\build\nscomptr.cpp @ 81]
xpcom_core!nsProxyEventObject::~nsProxyEventObject(void)+0x2b [c:\home\mozilla.org\mozilla\xpcom\proxy\src\nsproxyeventobject.cpp @ 74]
xpcom_core!nsProxyEventObject::Release(void)+0x6a [c:\home\mozilla.org\mozilla\xpcom\proxy\src\nsproxyeventobject.cpp @ 100]
xpcom_core!nsXPTCStubBase::Release(void)+0xd [c:\home\mozilla.org\mozilla\xpcom\reflect\xptcall\src\xptcall.cpp @ 66]
necko!nsCOMPtr<nsIDNSListener>::assign_assuming_AddRef(class nsIDNSListener * newPtr = 0x019eeea5)+0x2e [c:\home\mozilla.org\mozilla\dbg-firefox-i686-pc-mingw32\dist\include\xpcom\nscomptr.h @ 568]
necko!nsCOMPtr<nsIDNSListener>::assign_with_AddRef(class nsISupports * rawPtr = 0x019eeea5)+0x1a [c:\home\mozilla.org\mozilla\dbg-firefox-i686-pc-mingw32\dist\include\xpcom\nscomptr.h @ 1236]
necko!nsCOMPtr<nsIDNSListener>::operator=(class nsIDNSListener * rhs = 0x019eeea5)+0xc [c:\home\mozilla.org\mozilla\dbg-firefox-i686-pc-mingw32\dist\include\xpcom\nscomptr.h @ 714]
necko!nsDNSAsyncRequest::OnLookupComplete(class nsHostResolver * resolver = 0x00b75428, class nsHostRecord * hostRecord = 0x03e050d8, unsigned int status = 0)+0x93 [c:\home\mozilla.org\mozilla\netwerk\dns\src\nsdnsservice2.cpp @ 230]
necko!nsHostResolver::OnLookupComplete(class nsHostRecord * rec = 0x03e050d8, unsigned int status = 0, struct PRAddrInfo * result = 0x03e2e6b8)+0xd5 [c:\home\mozilla.org\mozilla\netwerk\dns\src\nshostresolver.cpp @ 652]
necko!nsHostResolver::ThreadFunc(void * arg = 0x00b75428)+0x82 [c:\home\mozilla.org\mozilla\netwerk\dns\src\nshostresolver.cpp @ 689]
nspr4!_PR_NativeRunThread(void * arg = 0x10204767)+0xdb [c:\home\mozilla.org\mozilla\nsprpub\pr\src\threads\combined\pruthr.c @ 436]
nspr4!pr_root(void * arg = 0x10204767)+0xd [c:\home\mozilla.org\mozilla\nsprpub\pr\src\md\windows\w95thred.c @ 120]
MSVCR80D!_callthreadstartex(void)+0x51 [f:\rtm\vctools\crt_bld\self_x86\crt\src\threadex.c @ 348]
MSVCR80D!_threadstartex(void * ptd = 0x03ce0668)+0x87 [f:\rtm\vctools\crt_bld\self_x86\crt\src\threadex.c @ 331]

could we just bite the bullet and make a threadsafe class for this? there are lots of consumers (clearly including networking itself) that need it.
confirmed; I'm hitting this assertion.

Steps to reproduce:
(1) Visit https://addons.mozilla.org/firefox/832/
(2) Install the tinderstatus add-on.

Assertion happens near the end of the installation, probably just as it's completing.
Incompatible extension dialog will appear; this is normal.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: testcase
Through bug 285337 this sounds like a dupe of bug 181160
(In reply to comment #2)
> Through bug 285337 this sounds like a dupe of bug 181160
> 

Umm ignore that last, blatantly not
OS: Windows XP → All
Hardware: PC → All
Hopefully, bug 708935 fixed this bug (if it was still happening.) too...
Depends on: 769764
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.