364274 - Incorrect state for static text in wizard dialogs

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Lynn Monsanto]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20060601 Firefox/2.0 (Ubuntu-edgy)
Build Identifier: version 3 alpha 1 (20061218)

The Account Wizard dialog has an accessible child for each block of static text. Each page (Identity, Server Information, etc.) has its own static text to be displayed when the user hits the next or back button to go to the next or previous page.  Assistive technologies, like Orca, need to speak the static text that's appropriate for the page the user is own.  The problem is that the accessible state for all the static text includes SHOWING and VISIBLE, even though the text may not be either showing or visible. Orca should only read the text that is showing and visible, so it needs get the correct state for the text.

Reproducible: Always

Steps to Reproduce:
1. Start the Thunderbird Account Wizard
2. Launch at-poke and open the subtree under the Account Wizard.
3. Click on any of the static text nodes. You will see that they are all SHOWING and VISIBLE.

Actual Results:  
See above.

Expected Results:  
See above

Comment 1

[Evan Yan]

confirmed.

it's a common problem of all wizard dialogs.
changing component to core::disability access API

Comment 2

[Nian Liu(n/a in a long time)]

2 issues here
1)element in a page under a deck should be grouped with each page.
2)element in non-current page under a deck should not be showing and visible

Comment 3

[Evan Yan]

the cause of this bug:
nsXULTextAccessible::GetState() returns STATE_READONLY directly, and we treat widgets as VISIBLE once INVISIBLE state is not set.

for issue 1) mentioned in comment #2, I think bug 357969 talks about that, right?

Comment 4

[Nian Liu(n/a in a long time)]

(In reply to comment #3)
> the cause of this bug:
> nsXULTextAccessible::GetState() returns STATE_READONLY directly, and we treat
> widgets as VISIBLE once INVISIBLE state is not set.

it's nothing wrong^_^ not invisible means visible

Comment 5

[Evan Yan]

(In reply to comment #4)
> it's nothing wrong^_^ not invisible means visible
> 
yes, I just meant that nsXULTextAccessible::GetState() should return INVISIBLE state explicitly when the widget is invisible.

Comment 6

[Nian Liu(n/a in a long time)]

> yes, I just meant that nsXULTextAccessible::GetState() should return INVISIBLE
> state explicitly when the widget is invisible.
> 
it's not related to nsXULTextAccessible::GetState(). xul element itself is visible, not invisible

Comment 7

[Nian Liu(n/a in a long time)]

(In reply to comment #6)
> > yes, I just meant that nsXULTextAccessible::GetState() should return INVISIBLE
> > state explicitly when the widget is invisible.
> > 
> it's not related to nsXULTextAccessible::GetState(). xul element itself is
> visible, not invisible
> 

my fault. i'd thought all accessible node is visible. in fact it's only for static text. sorry again.

Comment 8

[Evan Yan]

Attachment: call parent's GetState()

Comment 9

[Ginn Chen]

Comment on attachment 249907 [details] [diff] [review]
call parent's GetState()

since we touch here, we can change _retval to aState.