364299 - [cocoa] Two menu items can't have the same key equivalents (No keybinding set for History->Show In Sidebar, sometimes)

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[Asaf Romano (gone)]

Setting menuitem's checked attribute removes its key in cocoa widget.

STR:
1. Check View->Toolbars->History
2. Open the View->Toolbar menu again

-> History item's key (Cmd+Shift+H) is gone.

Note: autocheck is set to false for this item.

Comment 1

[Josh Aas]

The real problem here is that two menu items can't have the same key equivalents. The toolbars->history menu item is freaking out because History->"Show in Sidebar"  has the same key equiv.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I don't see why this is a problem.. two menu items shouldn't be able to have the same keybinding, fullstop.  Is the actual issue that the "newer/incoming" one overwrites the older one, and then causes the older one to disappear forever?

Comment 3

[Josh Aas]

If you assign the same keybinding to two different cocoa menu items, the behavior is probably going to be random as to which one retains the keybinding and which one doesn't. Unless there is a trick for getting them both to have it, we're just going to have to live with this. Which isn't *that* bad.

I have filed a bug with Apple and asked around, but its not looking like we'll find a better solution.

Comment 4

[Josh Aas]

Marking blocking1.9- because it is unlikely that we will fix this, you only get into this situation with questionable UI decisions, and they keyboard commands still work. Still a wanted fix though if we can get it.

Comment 5

[Michelle Funches - QA]

@Reporter: Please provide update if this is still a concern
-Menu functionality has been updated 
-Command Shift H still works and displays the History Sidebar
*Can Close
Version 	46.0.1
Build ID 	20160502172042
User Agent 	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:46.0) Gecko/20100101 Firefox/46.0

Comment 6

[Tracy Walker [:tracy]]

Resolved WFM