Closed
Bug 364309
Opened 18 years ago
Closed 18 years ago
Fix for bug 343168 has different behavior on different branches.
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: mrbkap)
References
Details
(Keywords: verified1.8.1.2)
Attachments
(2 files)
|
1.61 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
|
1.60 KB,
patch
|
jay
:
approval1.8.1.2+
|
Details | Diff | Splinter Review |
See bug 343168 comment 18 and following. Note that sorting this out blocks fixing bug 362837 on the stable branches...
|
Reporter | |
Updated•18 years ago
|
Flags: blocking1.8.1.2?
Flags: blocking1.8.0.10?
|
||
Comment 1•18 years ago
|
||
Let's get the correct fixes in for consistency from bug 343168, and then work on bug 362837.
Flags: blocking1.8.1.2?
Flags: blocking1.8.1.2+
Flags: blocking1.8.0.10?
Flags: blocking1.8.0.10+
|
|
||
Updated•18 years ago
|
Assignee: general → mrbkap
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•18 years ago
|
||
This makes trunk match the 1.8.0 behavior, which I think everybody agrees is the behavior we want here.
Attachment #250432 -
Flags: superreview?(bzbarsky)
Attachment #250432 -
Flags: review?(bzbarsky)
|
|
Reporter | |
Comment 3•18 years ago
|
||
Comment on attachment 250432 [details] [diff] [review]
Patch
Let's do it. Same for 1.8.1 branch, right?
Attachment #250432 -
Flags: superreview?(bzbarsky)
Attachment #250432 -
Flags: superreview+
Attachment #250432 -
Flags: review?(bzbarsky)
Attachment #250432 -
Flags: review+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•18 years ago
|
||
(In reply to comment #3)
> Let's do it. Same for 1.8.1 branch, right?
I'll wait for you to check the patch for bug 362837 in on the 1.8 branch before generating a branch patch (there are unrelated conflicts).
|
|
Reporter | |
Comment 6•18 years ago
|
||
> I'll wait for you to check the patch for bug 362837 in on the 1.8 branch
Done that.
|
|
Assignee | |
Comment 7•18 years ago
|
||
This isn't needed on the 1.8.0 branch.
Attachment #250849 -
Flags: approval1.8.1.2?
|
|
||
Updated•18 years ago
|
Flags: blocking1.8.0.10+
|
|
||
Comment 8•18 years ago
|
||
Comment on attachment 250849 [details] [diff] [review]
Branch patch
Approved for 1.8 branch, a=jay for drivers.
Attachment #250849 -
Flags: approval1.8.1.2? → approval1.8.1.2+
|
||
Comment 9•18 years ago
|
||
Who will check this into the 1.8 branch? mrbkap's back at sk00l, maybe could use a hand....
/be
|
||
Comment 10•18 years ago
|
||
Checking in nsHTMLDocument.cpp;
/cvsroot/mozilla/content/html/document/src/nsHTMLDocument.cpp,v <-- nsHTMLDocu
ment.cpp
new revision: 3.615.2.35; previous revision: 3.615.2.34
done
Checked in on the 1.8.1 branch.
Keywords: fixed1.8.1
|
||
Updated•18 years ago
|
Keywords: fixed1.8.1 → fixed1.8.1.2
|
||
Comment 11•18 years ago
|
||
Verified using testcases in bug 343168 and bug 362837 on: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2pre) Gecko/20070207 BonEcho/2.0.0.2pre
Behavior seems consistent in both branches.
Keywords: fixed1.8.1.2 → verified1.8.1.2
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•