36440 - JPN chars in an address book card are printed out as dots.

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P3)

Description

[ji]

Build: 2000-04-19-09 commercial 

Now we can print out address book card, but Japanese characters in an
address book card are printed out as dots.

Steps of reproduce:

1. Launch Address Book.
2. Create a card with Japanese firstname and lastname.
3. Select File | Print Card View...

The Japanese firstname and lastname are displayed as dots in the print preview
window and those Japanese chars are actually printed out as dots as well.

Comment 1

[nhottanscp]

Reassign to chuang. Let us know if you need test cases.

Comment 2

[chuang]

CC Rich for his attention

Comment 3

[Makoto Kato [:m_kato]]

http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/src/nsAddbookProtocolH
andler.cpp#428

420   // Ok, this is the place where we need to generate output for either a 
single entry
421   // or the entire table...
422   //
423   if (mAddbookOperation == nsIAddbookUrlOperation::PrintIndividual)
424     rv = BuildSingleHTML(aDatabase, directory, charEmail, workBuffer);
425   else
426     rv = BuildAllHTML(aDatabase, directory, workBuffer);
427 
428   *outBuf = workBuffer.ToNewCString();
429 
430 EarlyExit:
431   // Database is open...make sure to close it


This problem is line 428.  We should change this line to the following...

  *outBuf = workBuffer.ToNewUTF8String();


On my Windows 2000 box, it works fine by this change.

Comment 4

[nhottanscp]

He is right, I get assertions at ToNewCString when printing Japanese cards.
Rich, could you review?

Index: nsAddbookProtocolHandler.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/addrbook/src/nsAddbookProtocolHandler.cpp,v
retrieving revision 1.5
diff -c -r1.5 nsAddbookProtocolHandler.cpp
*** nsAddbookProtocolHandler.cpp	2000/03/31 02:21:37	1.5
--- nsAddbookProtocolHandler.cpp	2000/04/21 16:22:56
***************
*** 425,431 ****
    else
      rv = BuildAllHTML(aDatabase, directory, workBuffer);
  
!   *outBuf = workBuffer.ToNewCString();
  
  EarlyExit:
    // Database is open...make sure to close it
--- 425,431 ----
    else
      rv = BuildAllHTML(aDatabase, directory, workBuffer);
  
!   *outBuf = workBuffer.ToNewUTF8String();
  
  EarlyExit:
    // Database is open...make sure to close it

Comment 5

[chuang]

Rich is not available today.  The patch looks fine to me.  I assume it works for 
English too.  Can you also try on an address book with Japanese address book 
name?  I want to know if it's working.  Thanks.

Comment 6

[nhottanscp]

I tried with Japanese addressbook name. It printed out fine but got an assertion 
at following line of nsAbCardProperty.cpp.
1281   char *dirCharStr = dirNameStr.ToNewCString();

It is expected that the addressbook name to be printed somewere?

Comment 7

[chuang]

When I pass the address book print url (which contains the address book name) to 
Rich's print engine,  I just wonder if  the way I did is ok for double byte 
character.  If the assertion is not serious, then I guess the url is passed 
correctly.  

Comment 8

[nhottanscp]

You can use this for encoding URI (use "UTF-8" for charset) instead of 
ToNewCString.
string nsITextToSubURI::ConvertAndEscape(in string charset, in wstring text);
Then other side to call decoding function.
wstring UnEscapeAndConvert(in string charset, in string text);

Anyway, can I check in the patch for nsAddbookProtocolHandler.cpp?

Comment 9

[chuang]

Yes, go ahead to check it in.  Please mark it fixed after you check in.  Thanks.

Comment 10

[nhottanscp]

Checked in the fix, thank you for the contribution.

Comment 11

[Katsuhiko Momoi]

ji, please verify this against a current build.

Comment 12

[ji]

Verified as fixed with 2000042709 win32 commercial build.