364420 - Monthly layout: Left-align events on monthly calendar

Status: RESOLVED FIXED

(Calendar :: Printing, enhancement)

Description

[Carl Ponder]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061116 Fedora/1.5.0.8-2_EL4 (CK-IBM) (CK-IBM) Firefox/1.5.0.8
Build Identifier: SunBird 0.3

I print the "calendarPrint.html" file using the "opera" browser, so I can get a full month grid on tabloid paper. It's a bit odd that the events are horizontally centered; it would look better if they are all left-aligned.

Reproducible: Always

Comment 1

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

The event time and description in the "Monthly Grid" should appear left aligned.

Is a second review needed for this small fix?

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 252363 [details] [diff] [review]
Patch v1

>Index: calMonthGridPrinter.js
>===================================================================
>             } catch(ex) {}
> 
>             var style = 'font-size: 11px; background-color: ' + calColor + ';';
>             style += ' color: ' + getContrastingTextColor(calColor);
>             if (catColor) {
>                 style += ' border: solid ' + catColor + ' 2px;';
>             }
>             var item = <tr>
>-                           <td valign='top' align='center' style={style}>{time} {item.title}</td>
>+                           <td valign='top' align='left' style={style}>{time} {item.title}</td>
>                        </tr>;
>             innerTable.appendChild(item);
>         }

I'd rather move more formatting into CSS if possible.
Remove the align='center' and try adding 'text-align=left;' to style above.

Does this produce the same result?

Comment 3

[Martin Schröder [:mschroeder]]

Attachment: Patch v2

Moved alignment to var style as suggested. This produced the same result.

Comment 4

[Matthew (lilmatt) Willis]

Comment on attachment 252449 [details] [diff] [review]
Patch v2

Nice. r=lilmatt

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

We all like screenshots... (hint, hint)

Comment 6

[Martin Schröder [:mschroeder]]

Attachment: Old preview with centered events

Comment 7

[Martin Schröder [:mschroeder]]

Attachment: New preview with left-aligned events

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 252449 [details] [diff] [review]
Patch v2

r2=mvl

Comment 9

[Carl Ponder]

This looks like what I want, thanks!

Comment 10

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED