Closed Bug 364499 Opened 18 years ago Closed 17 years ago

Test Bouncer and Software Update before going live with updates

Categories

(Toolkit :: Application Update, defect)

1.8 Branch
PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: marcia, Assigned: preed)

Details

(Keywords: fixed1.8.0.10, fixed1.8.1.2)

Attachments

(2 files, 3 obsolete files)

Filing this as a tracking bug, to track what we need to do to test bouncer scenarios before we go live with software updates. If this needs to be moved to another component, we can do so if necessary.
Flags: blocking1.8.1.2?
Flags: blocking1.8.0.10?
Flags: blocking1.8.1.2?
Flags: blocking1.8.1.2+
Flags: blocking1.8.0.10?
Flags: blocking1.8.0.10+
Taking.
Assignee: nobody → preed
Preed: Please add the fixed1.8.x.x keywords when this infrastructure change is in place... so it doesn't show up on drivers radar.  Thanks!
(In reply to comment #2)
> Preed: Please add the fixed1.8.x.x keywords when this infrastructure change is
> in place... so it doesn't show up on drivers radar.  Thanks!

Will do. You'll see a patcher checkin for this, though.
Adds the ability to do per-AUS channel URLs, so in the config, you can now do:

url = "http://bar"
betatest-url = "http://foo"
releasetest-url = "http://baz"

Any channel that doesn't have a $channelName-url specified will get whatever's in url.
Attachment #252411 - Flags: review?(rhelmer)
Whiteboard: need review=rhelmer
Attached patch Take 2 (obsolete) — Splinter Review
This version is better; it makes it so you can also customize the release channels (in addition to the channels that are listed as testchannels) and I forgot to put this logic into CreatePastReleasePatchinfo(). This version doesn't make that omission.
Attachment #252411 - Attachment is obsolete: true
Attachment #252945 - Flags: review?(rhelmer)
Attachment #252411 - Flags: review?(rhelmer)
Attached patch Take 3 (obsolete) — Splinter Review
This is take 2's patch, but corrected to actually apply and compile.

I was trying to use quilt to do some patch management, and clearly, I failed.
Attachment #252945 - Attachment is obsolete: true
Attachment #252961 - Flags: review?(rhelmer)
Attachment #252945 - Flags: review?(rhelmer)
Comment on attachment 252961 [details] [diff] [review]
Take 3

Looks good to me. I can do a test run, if you like.
Attachment #252961 - Flags: review?(rhelmer) → review+
Attached patch Take 4Splinter Review
Just a refresh of take 3, adjusted for the latest patch for bug 366650 landing.
Attachment #252961 - Attachment is obsolete: true
Attachment #252981 - Flags: review?(rhelmer)
Ok, did a quick test, here is what I did:

* added "blahtest" channel to testchannels
* set url as: 
  blahtest-url = "WORKING"

I see blahtest channels with the proper URL, so that part is working, and besides that the output is identical to my previous test run with the currently checked in code.

I like this much better than the hardcoded channel names in patcher2.pl, good job!

The only thing I have not tested is if this works for previous updates; I can test that too before you checkin if you like. It'll take longer than the setup I have now, let me know.
Attachment #252981 - Flags: review?(rhelmer) → review+
Landed:

Checking in patcher2.pl;
/cvsroot/mozilla/tools/patcher/patcher2.pl,v  <--  patcher2.pl
new revision: 1.12; previous revision: 1.11
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
We can support this now; as a process change, we'll setup patcher2 up in the future to point the betatest channels at stage and the releasetest channels at bouncer{1,2}.
Whiteboard: need review=rhelmer
Rhelmer found a bug with the take 4 patch; reopening for the fix.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fixes three issues, in order of diff chunkage:

1. In the complete patch snippet creation, if we had a channel-specific URL specified for one of the NON-test channels, but NO channel-specific URL specified for the test channels, we'd pick up the channel-specific URL from the non-test channel, not the default URL, as we should.

2. 'testurl' is no longer a valid config option, so remove reference to it in patcher2.pl.

3. In the partial, test channel snippet creation, if there was no channel-specific url specified, we'd give the generated *path* to the file, not the URL. That's obviously wrong.
Attachment #253433 - Flags: review?(rhelmer)
Comment on attachment 253433 [details] [diff] [review]
Fix a problem where we conflated path w/ url

preedPatcherHate++
Attachment #253433 - Flags: review?(rhelmer) → review+
Checking in patcher2.pl;
/cvsroot/mozilla/tools/patcher/patcher2.pl,v  <--  patcher2.pl
new revision: 1.13; previous revision: 1.12
done
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
preed: at the QA meeting today we talked through how we would test this before release. can you clarify this for us prior to the release? Thanks.
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: