364518 - mouse scroll wheel stopped working since Fx 2.0.0.1

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[dominique Carturan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1

i have installed the update and i have now the version 2.0.0.1 but now i can't use the wheel of my mouse anymore ! ! ! have an explanation for this problem because the wheel of my mouse is already operationnal when i use internet explorer or avant browser ? ? ?

Reproducible: Always

Comment 1

[Ria Klaassen (not reading all bugmail)]

http://forums.mozillazine.org/viewtopic.php?t=501574&highlight=

Comment 2

[Carsten Book [:Tomcat]]

*** Bug 364630 has been marked as a duplicate of this bug. ***

Comment 3

[Phil Ringnalda (:philor)]

*** Bug 364658 has been marked as a duplicate of this bug. ***

Comment 4

[Masatoshi Kimura [:emk]]

I believe this is a regression from bug 347875.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

What mouse driver has this bug?
And can you test with trunk build?

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

taking. I'll attach the patch. The problem may happen only with legacy message.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

I think that this patch fixes this bug. But I don't have the moues.

And trunk build has dropped the support of the legacy message, should we recover the support on trunk too?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Kimura-san said in bugzilla-jp:

"Probably, if we don't process the legacy message, the mouse drivers use WM_MOUSEWHEEL intead of it. Therefore, we don't have the regression reports on trunk build."

I agree to this.

Comment 9

[Ner0lph]

This bug is also on Windows 98 SE.

Comment 10

[Ere Maijala (slow)]

Comment on attachment 249504 [details] [diff] [review]
Patch rv1.0

Can someone verify this patch works?

What legacy message do you mean and where in the patch for bug 347875 was it dropped?

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #10)
> (From update of attachment 249504 [details] [diff] [review])
> Can someone verify this patch works?

I don't have the mouse :-(

> What legacy message do you mean and where in the patch for bug 347875 was it
> dropped? 

No, it has dropped at bug 330276.
attachment 216511 [details] [diff] [review]:
> -#if !defined (__MINGW32__) && !defined(WINCE) 
> -  if (!nsWindow::uMSH_MOUSEWHEEL)
> -    nsWindow::uMSH_MOUSEWHEEL = RegisterWindowMessage(MSH_MOUSEWHEEL);
> -#endif
> -  

Comment 12

[Ere Maijala (slow)]

Ok, nasty side-effects of a seemingly valid change. Could you try to find someone who could verify the change, please? I can't test it either.

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I uploaded the patched build in my server. Can you test the build, dominique Carturan or anybody?
http://www.d-toybox.com/mozilla/testbuilds/bug364518.zip

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ere:

http://forums.mozillazine.org/viewtopic.php?t=501574&postdays=0&postorder=asc&postsperpage=15&start=15&sid=81bab3df202a5b97ce91fe6246561ad9
I get the feedback in Mozillazine forum. He said the patched build works fine.

Comment 15

[Ere Maijala (slow)]

Comment on attachment 249504 [details] [diff] [review]
Patch rv1.0

Ok, good. r=emaijala

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 249504 [details] [diff] [review]
Patch rv1.0

Thank you, Ere.

Roc, would you check for sr?

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Could you slightly simplify this by setting

int verticalAmount = msg == WM_MOUSEWHEEL ? (short) HIWORD (wParam) : (int) wParam;

above "if (ulScrollLines == WHEEL_PAGESCROLL)", and then using it in both cases?

Comment 18

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.1

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Roc:

Would you continue to sr?

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 250583 [details] [diff] [review]
Patch rv1.1

This patch is only needed by 1.8 branch.

Comment 21

[Jay Patel [:jay]]

Comment on attachment 250583 [details] [diff] [review]
Patch rv1.1

Approved for 1.8 branch, a=jay for drivers.

Comment 22

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Would somebody verify in nightly builds?

Comment 23

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, available the nightly builds:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8/

# after 10, Jan.

Would you verify the fix?

Comment 24

[Tony Chung [:tchung]]

Dont have the mouse driver for the mouse listed here.  But i installed the build from the link above and verified my kensington wireless mouse scrollwheel works fine.  

Comment 25

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I get the feedback from Japanese tester.

-> v1.8.1.2.