feeds component should not run tests when tests are disabled

RESOLVED WONTFIX

Status

--
trivial
RESOLVED WONTFIX
12 years ago
6 months ago

People

(Reporter: allan, Unassigned)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
toolkit/components/feeds/Makefile.in

(I was a bit unsure about whether this should be in build or toolkit/somthing)
(Reporter)

Comment 1

12 years ago
Created attachment 249343 [details] [diff] [review]
Patch
Attachment #249343 - Flags: review?
(Reporter)

Updated

12 years ago
Attachment #249343 - Flags: review? → review?(benjamin)

Comment 2

12 years ago
Comment on attachment 249343 [details] [diff] [review]
Patch

I'm not sure what we gain by doing this: "make check" is useless when tests are disabled, so why are we bothering to ifdef out the lines?
(Reporter)

Comment 3

12 years ago
If you have build systems running with a fixed list of targets they run, ie. they always run "make check", it would be nice to have that target be noop when tests are disabled.

feeds is also the only dir. that actually does anything on 'make check' with tests disabled.

Comment 4

12 years ago
I don't think it's especially readable or useful to wrap every check: rule in a MOZ_ENABLE_TESTS wrapper. We don't (and won't) have a build system that runs "make check" unconditionally.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WONTFIX

Updated

12 years ago
Attachment #249343 - Flags: review?(benjamin)
(Reporter)

Comment 5

12 years ago
Well well, it's not like it is important to me. I'll just note that a) it is the only thing being run in my tree, and b) there could exist other people than "the happy @mozilla.com crowd" that would be silly enough to have a build system running.

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.