364576 - feeds component should not run tests when tests are disabled

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Allan Beaufour]

toolkit/components/feeds/Makefile.in

(I was a bit unsure about whether this should be in build or toolkit/somthing)

Comment 1

[Allan Beaufour]

Attachment: Patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 249343 [details] [diff] [review]
Patch

I'm not sure what we gain by doing this: "make check" is useless when tests are disabled, so why are we bothering to ifdef out the lines?

Comment 3

[Allan Beaufour]

If you have build systems running with a fixed list of targets they run, ie. they always run "make check", it would be nice to have that target be noop when tests are disabled.

feeds is also the only dir. that actually does anything on 'make check' with tests disabled.

Comment 4

[Benjamin Smedberg]

I don't think it's especially readable or useful to wrap every check: rule in a MOZ_ENABLE_TESTS wrapper. We don't (and won't) have a build system that runs "make check" unconditionally.

Comment 5

[Allan Beaufour]

Well well, it's not like it is important to me. I'll just note that a) it is the only thing being run in my tree, and b) there could exist other people than "the happy @mozilla.com crowd" that would be silly enough to have a build system running.