toolkit/components/feeds/Makefile.in (I was a bit unsure about whether this should be in build or toolkit/somthing)
Attachment #249343 - Flags: review? → review?(benjamin)
Comment on attachment 249343 [details] [diff] [review] Patch I'm not sure what we gain by doing this: "make check" is useless when tests are disabled, so why are we bothering to ifdef out the lines?
If you have build systems running with a fixed list of targets they run, ie. they always run "make check", it would be nice to have that target be noop when tests are disabled. feeds is also the only dir. that actually does anything on 'make check' with tests disabled.
I don't think it's especially readable or useful to wrap every check: rule in a MOZ_ENABLE_TESTS wrapper. We don't (and won't) have a build system that runs "make check" unconditionally.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WONTFIX
Well well, it's not like it is important to me. I'll just note that a) it is the only thing being run in my tree, and b) there could exist other people than "the happy @mozilla.com crowd" that would be silly enough to have a build system running.
You need to log in before you can comment on or make changes to this bug.