364827 - PlacesController efficiency improvements

Status: RESOLVED DUPLICATE of bug 364828

(Firefox :: Bookmarks & History, defect)

Description

[Asaf Romano (gone)]

As mentioned on the best place to report your bugs (/msg sspitzer), the patch on bug 359462 is supposed to slow us down a bit esp. once places-based bookmarks is enabled for two reasons:
 1. All supported commands are updated for each focus/select event.
 2. _selectionOverlapsSystemArea and _canInsert are called for each coomand, no caching is done.

Together, these are a real hit in the browser window, and is esp. wrong since it has no focusable views. My plan is to fix first fix the events issue by updating places-specific commands on a places-specific event (someting like window.updateCommands("PlacesCommands")). We'll still go through the PlacesController(s) for focus/select events, I don't consider this an issue since the enableEditCommands property of each view is checked by its PlacesController before any further check is done.

I'm not yet sure what to do with the second issue here, it might not worth the necessary code complexity once the events issue is addressed.

Comment 1

[Asaf Romano (gone)]

*** This bug has been marked as a duplicate of 364828 ***

Comment 2

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv