364867 - "WARNING: Textframe maps no content" on many websites

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Frank Wein [:mcsmurf]]

With a current debug trunk build on Win2k I get this warning
WARNING: Textframe maps no content: file h:/mozilla/tree-main/mozilla/layout/gen
eric/nsTextFrame.cpp, line 4945
many times on various websites. I think this started with the landing of the reflow branch, but this is only a rough guess (I do not build debug trunk builds every day).

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Testcase

Comment 2

[Jesse Ruderman]

This warning appears very frequently, making it difficult to see other console output.

Comment 3

[Frank Wein [:mcsmurf]]

BTW: The warning was added as part of Bug 343445, not as part of reflow branch.

Comment 4

[Lars Huttar]

Confirming that this occurs in
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070302
Minefield/3.0a3pre

Again, the warning occurs so frequently that it's difficult to see other console output.

Comment 5

[Robert Sayre]

Attachment: ifdef 0

this is happening far too often, and disrupts people who aren't working on layout.

To make a positive contribution, I will see if I can figure out a fix for at least some of the situations that cause this. However, I don't know this code.

Comment 6

[Robert Sayre]

All instances of this warning I have observed are due to nsTextFrame *aBefore having a ContentOffset of 0 and a ContentLength of 0.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 257259 [details] [diff] [review]
ifdef 0

I was going to just fix this but that's actually kinda hard and this code will be going away in favour of the new textframe code (which works entirely differently and has no equivalent assertion) so might as well just disable it for now. Sorry for the delay.

Comment 8

[Robert Sayre]

Checking in nsTextFrame.cpp;
/cvsroot/mozilla/layout/generic/nsTextFrame.cpp,v  <--  nsTextFrame.cpp
new revision: 1.620; previous revision: 1.619
done

Comment 9

[Phil Ringnalda (:philor)]

Fixed in the best of all possible ways, cvs rm.