Open
Bug 364895
Opened 19 years ago
Updated 12 years ago
atom feed for secure bugs needs to list groups
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Tracking
()
NEW
People
(Reporter: timeless, Unassigned)
Details
(Keywords: ue)
Attachments
(1 file)
2.25 KB,
patch
|
LpSolit
:
review-
|
Details | Diff | Splinter Review |
"@" is *not* discoverable! i had to read the source to figure out what it meant.
The atom feed needs to list the groups the bug is in.
Attachment #249572 -
Flags: review?(reed)
Attachment #249572 -
Flags: review?(justdave)
Attachment #249572 -
Flags: review?
![]() |
||
Comment 2•19 years ago
|
||
Comment on attachment 249572 [details] [diff] [review]
is this ok
> <th>Field</th><th>Value</th>
>+ [% IF bug.secure_mode %]
> </tr><tr>
>+ <th>Groups</th>
The indentation is incorrect. Everything inside the IF block must be indented accordingly.
![]() |
||
Updated•19 years ago
|
Attachment #249572 -
Flags: review?(reed)
![]() |
||
Comment 3•18 years ago
|
||
Comment on attachment 249572 [details] [diff] [review]
is this ok
>+ [% FOREACH group = bug.groups %]
bug.groups lists all groups the bug *could* belong to, or those which are used for local privs. That's not what you want.
>+ [% IF list_started %]
>+ [% ", " %]
>+ [% ELSE %]
>+ [% list_started = 1 %]
>+ [% END %]
A join() would be much cleaner.
Also, my previous comment still applies.
Attachment #249572 -
Flags: review?(justdave) → review-
![]() |
||
Updated•18 years ago
|
Severity: major → normal
OS: Windows XP → All
Hardware: PC → All
![]() |
||
Updated•13 years ago
|
Severity: normal → enhancement
![]() |
||
Updated•12 years ago
|
Assignee: timeless → create-and-change
![]() |
||
Updated•12 years ago
|
Status: ASSIGNED → NEW
You need to log in
before you can comment on or make changes to this bug.
Description
•