Open Bug 364895 Opened 19 years ago Updated 12 years ago

atom feed for secure bugs needs to list groups

Categories

(Bugzilla :: Creating/Changing Bugs, enhancement)

2.23.3
enhancement
Not set
normal

Tracking

()

People

(Reporter: timeless, Unassigned)

Details

(Keywords: ue)

Attachments

(1 file)

"@" is *not* discoverable! i had to read the source to figure out what it meant. The atom feed needs to list the groups the bug is in.
Attached patch is this okSplinter Review
Assignee: create-and-change → timeless
Status: NEW → ASSIGNED
Attachment #249572 - Flags: review?
Attachment #249572 - Flags: review?(reed)
Attachment #249572 - Flags: review?(justdave)
Attachment #249572 - Flags: review?
Comment on attachment 249572 [details] [diff] [review] is this ok > <th>Field</th><th>Value</th> >+ [% IF bug.secure_mode %] > </tr><tr> >+ <th>Groups</th> The indentation is incorrect. Everything inside the IF block must be indented accordingly.
Attachment #249572 - Flags: review?(reed)
Comment on attachment 249572 [details] [diff] [review] is this ok >+ [% FOREACH group = bug.groups %] bug.groups lists all groups the bug *could* belong to, or those which are used for local privs. That's not what you want. >+ [% IF list_started %] >+ [% ", " %] >+ [% ELSE %] >+ [% list_started = 1 %] >+ [% END %] A join() would be much cleaner. Also, my previous comment still applies.
Attachment #249572 - Flags: review?(justdave) → review-
Severity: major → normal
OS: Windows XP → All
Hardware: PC → All
Severity: normal → enhancement
Assignee: timeless → create-and-change
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: